From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9023823BD01; Sat, 1 Nov 2025 12:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762000870; cv=pass; b=fC+kCYqsM2asGktoaI9nsbPobz4w0HTZwq9VK+L8JjVnRF36wMU4mtS+Obbes2WBPkrQmLJfWDdsNBvAwupSlmq5n0F0TT0GB3ZmWzgXG4zlFUTc9s6j5hknmYlCbB1mFi/6dnjBPPuFfJXdf3Qbj76zvSL2APx3um69shrlD3A= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762000870; c=relaxed/simple; bh=Xx4k/fa+z5oSv3/s6q/fkvdh6lOYHQhINeo6yjxMnCM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=X2kfL1u9nkQgcjWMa7NgpheN9rzmyoO3Wyn9Mfn29cUgoFteCZaaDam12VeiW+whAddZmGDBLSsIKZAFUJqithEmTeON7s3Sh8lYubVhlo2uB4EKh2ltIvjEjNloy8nKC3kKe48q3KNHjIN19j0ZlUZ29uyy8EbMeW2uFoScvb4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=sjoerd@collabora.com header.b=hVxDDM/g; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=sjoerd@collabora.com header.b="hVxDDM/g" ARC-Seal: i=1; a=rsa-sha256; t=1762000821; cv=none; d=zohomail.com; s=zohoarc; b=A7QggDksDzCmseQYSFGx/xof5FXoKWhxWCF1voGnOqira6R7CpXcFOe0adxPrhAfq46N1HjN76y4RmHjG2MKHWqbGxvwsMyJVal7+yN2yaVxHACMWl+iV2XKLZ756ZfiGeB7GPOMfmO5c2NiDuOqi33nIosp10r5BtTbdXDjSu0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762000821; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=wX50N1iHvuUcfFTPrDTk6BLpkXD7It4diuWw8d34XeY=; b=IRfmqhYlU29u+cfbSc2SPpAMwbA9jqEXzZ2q6s4FAq/fo8xrlDQSrLa8qvj+KfyhxxoqqjfejRhYxARtTv0si7j9gCxYbC/wfSsPcXJeow/Nupy5oK9uEUoQqa+vx/v1KKRRxXaopfS8uW9e92K+MwM/7lXIx+A+HLzbpKdLB3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sjoerd@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1762000821; s=zohomail; d=collabora.com; i=sjoerd@collabora.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Message-Id:Reply-To; bh=wX50N1iHvuUcfFTPrDTk6BLpkXD7It4diuWw8d34XeY=; b=hVxDDM/gqRw68T07nRuvdrHGupRkXhOU8RexT1UeP+9bS+r2KO4yzzfNJKjP+80C 7ABb6CAL4qYLI3lXalMwKyt2SNufHOI19Bfnb3DH6aWQUjo7eCQ7Z9iLnS5/At0SWAQ DMYA4onW8qA2XN4liLwbv9J0ttSlgEbygWhi/Tro= Received: by mx.zohomail.com with SMTPS id 1762000816267360.6637248664106; Sat, 1 Nov 2025 05:40:16 -0700 (PDT) Message-ID: <548101c6c887299b3c39f294e376c782e0bd2160.camel@collabora.com> Subject: Re: [PATCH 13/15] arm64: dts: mediatek: mt7981b: Add wifi memory region From: Sjoerd Simons To: AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Lee Jones , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi , Felix Fietkau Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, netdev@vger.kernel.org, Daniel Golle , Bryan Hinton Date: Sat, 01 Nov 2025 13:40:06 +0100 In-Reply-To: <9bf32a56-b67f-488a-8719-3f97d85533d3@collabora.com> References: <20251016-openwrt-one-network-v1-0-de259719b6f2@collabora.com> <20251016-openwrt-one-network-v1-13-de259719b6f2@collabora.com> <9bf32a56-b67f-488a-8719-3f97d85533d3@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-7 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ZohoMailClient: External On Thu, 2025-10-16 at 13:28 +0200, AngeloGioacchino Del Regno wrote: > Il 16/10/25 12:08, Sjoerd Simons ha scritto: > > Add required memory region for the builtin wifi block. Disable the bloc= k > > by default as it won't function properly without at least pin muxing. > >=20 > > Signed-off-by: Sjoerd Simons >=20 > You should split this commit in two: > =C2=A0 - Add wifi memory region > =C2=A0 - Disable wifi by default Will split. > Regarding the second commit, you have to re-enable the wifi node in all o= f > the currently supported MT7981b devices, including: > =C2=A0 - Xiaomi AX3000T > =C2=A0 - Cudy WR3000 V1 >=20 > While I agree that without pin muxing the wifi may not properly work, it = is > unclear whether the aforementioned devices are pre-setting the pinmux in = the > bootloader before booting Linux. >=20 > In case those do, you'd be "breaking" WiFi on two routers here. Wifi will never have worked on those upstream; The driver hits an unconditi= onal -EINVAL during probe due to the missing memory-region this patch adds. I'll make sure to note t= hat in the new disable patch. --=20 Sjoerd Simons