Re: [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD

[Jianhua Xie <jianhua.xie@freescale.com>]

在 2014年12月05日 12:14, Roopa Prabhu 写道:
> On 12/4/14, 7:25 PM, Jianhua Xie wrote:
>>
>> 在 2014年12月05日 10:26, roopa@cumulusnetworks.com 写道:
>>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>>
>>> This patch just sets the feature flag on rocker ports
>>> ---
>>>   drivers/net/ethernet/rocker/rocker.c |    3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/rocker/rocker.c 
>>> b/drivers/net/ethernet/rocker/rocker.c
>>> index fded127..3fe19b0 100644
>>> --- a/drivers/net/ethernet/rocker/rocker.c
>>> +++ b/drivers/net/ethernet/rocker/rocker.c
>>> @@ -4003,7 +4003,8 @@ static int rocker_probe_port(struct rocker 
>>> *rocker, unsigned int port_number)
>>>                  NAPI_POLL_WEIGHT);
>>>       rocker_carrier_init(rocker_port);
>>>   -    dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
>>> +    dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER |
>>> +                     NETIF_F_HW_SWITCH_OFFLOAD;
>> Do you have a plan on enabling/disabling  this flag dynamically by 
>> ethtool?
>
> I have not thought about it yet. But if this gets accepted, then yes, 
> I will have an ethtool way for drivers who want it.
> if we have a IFF_ flag for this (which is also one of my alternate 
> proposals), there will be a netlink way to set it on and off.
>
Got it with thanks.
Best Regards.
Jianhua