Re: [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD

[John Fastabend <john.fastabend@gmail.com>]

On 12/04/2014 10:16 PM, Scott Feldman wrote:
> On Thu, Dec 4, 2014 at 7:25 PM, Jianhua Xie <jianhua.xie@freescale.com> wrote:
>>
>> 在 2014年12月05日 10:26, roopa@cumulusnetworks.com 写道:
>>
>>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>>
>>> This patch just sets the feature flag on rocker ports
>>> ---
>>>    drivers/net/ethernet/rocker/rocker.c |    3 ++-
>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/rocker/rocker.c
>>> b/drivers/net/ethernet/rocker/rocker.c
>>> index fded127..3fe19b0 100644
>>> --- a/drivers/net/ethernet/rocker/rocker.c
>>> +++ b/drivers/net/ethernet/rocker/rocker.c
>>> @@ -4003,7 +4003,8 @@ static int rocker_probe_port(struct rocker *rocker,
>>> unsigned int port_number)
>>>                         NAPI_POLL_WEIGHT);
>>>          rocker_carrier_init(rocker_port);
>>>    -     dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
>>> +       dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER |
>>> +                                        NETIF_F_HW_SWITCH_OFFLOAD;
>>
>> Do you have a plan on enabling/disabling  this flag dynamically by ethtool?
>
> Might get it for free if we recycle NETIF_F_HW_L2FW_DOFFLOAD;
> NETIF_F_HW_L2FW_DOFFLOAD seems to be supported by ethtool already.

See my other note but ethtool support for feature flags makes
this pretty close to trivial to implement these days.

Take a look @ netdev_features_strings.

>
>>
>> Thanks & B.R
>> Jianhua
>>
>>>          err = register_netdev(dev);
>>>          if (err) {
>>
>>


-- 
John Fastabend         Intel Corporation