From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() Date: Fri, 05 Dec 2014 09:04:16 +0100 Message-ID: <54816700.6090501@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> <5480DBDE.7040604@users.sourceforge.net> <1417731809.2721.17.camel@perches.c om> <5480DFB5.4090708@users.sourceforge.net> <1417733101.2721.20.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , LKML , kernel-janitors@vger.kernel.org To: Julia Lawall , Joe Perches Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > Markus, are you sure that you cannot use netdev_warn in this case? No. - I did not become familiar enough with the software infrastructure around the mppe_rekey() function. I do not see so far how I could determine a pointer for the first parameter there. The data structure "ppp_mppe_state" (which is referenced by the input variable "state") does not contain corresponding context information, does it? Regards, Markus