From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roopa Prabhu Subject: Re: [PATCH 2/3] bridge: offload bridge port attributes to switch asic if feature flag set Date: Fri, 05 Dec 2014 05:44:10 -0800 Message-ID: <5481B6AA.9020502@cumulusnetworks.com> References: <1417746401-8140-3-git-send-email-roopa@cumulusnetworks.com> <20141205073840.GA1866@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: sfeldma@gmail.com, jhs@mojatatu.com, bcrl@kvack.org, tgraf@suug.ch, john.fastabend@gmail.com, stephen@networkplumber.org, linville@tuxdriver.com, nhorman@tuxdriver.com, nicolas.dichtel@6wind.com, vyasevic@redhat.com, f.fainelli@gmail.com, buytenh@wantstofly.org, aviadr@mellanox.com, netdev@vger.kernel.org, davem@davemloft.net, shm@cumulusnetworks.com, gospo@cumulusnetworks.com To: Jiri Pirko Return-path: Received: from ext3.cumulusnetworks.com ([198.211.106.187]:60809 "EHLO ext3.cumulusnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626AbaLENo1 (ORCPT ); Fri, 5 Dec 2014 08:44:27 -0500 In-Reply-To: <20141205073840.GA1866@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On 12/4/14, 11:38 PM, Jiri Pirko wrote: > Fri, Dec 05, 2014 at 03:26:40AM CET, roopa@cumulusnetworks.com wrote: >> From: Roopa Prabhu >> >> This allows offloading to switch asic without having the user to set >> any flag. And this is done in the bridge driver to rollback kernel settings >> on hw offload failure if required in the future. >> >> With this, it also makes sure a notification goes out only after the >> attributes are set both in the kernel and hw. >> --- >> net/bridge/br_netlink.c | 27 ++++++++++++++++++++++++++- >> 1 file changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c >> index 9f5eb55..ce173f0 100644 >> --- a/net/bridge/br_netlink.c >> +++ b/net/bridge/br_netlink.c >> @@ -407,9 +407,21 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh) >> afspec, RTM_SETLINK); >> } >> >> + if ((dev->features & NETIF_F_HW_SWITCH_OFFLOAD) && >> + dev->netdev_ops->ndo_bridge_setlink) { >> + int ret = dev->netdev_ops->ndo_bridge_setlink(dev, nlh); > This (and I suspect other patches as well) has many issues which > are pointed out by scripts/checkpatch.pl sctipts. For example > here, there should be an empty line. Please run your patches by > this script before you send them. ack, sure thing (I usually do but forgot yesterday). > >> + if (ret && ret != -EOPNOTSUPP) { >> + /* XXX Fix this in the future to rollback >> + * kernel settings and return error >> + */ >> + br_warn(p->br, "error offloading bridge attributes " >> + "on port %u(%s)\n", (unsigned int) p->port_no, >> + p->dev->name); >> + } >> + } >> + >> if (err == 0) >> br_ifinfo_notify(RTM_NEWLINK, p); >> - >> out: >> return err; >> } >> @@ -433,6 +445,19 @@ int br_dellink(struct net_device *dev, struct nlmsghdr *nlh) >> err = br_afspec((struct net_bridge *)netdev_priv(dev), p, >> afspec, RTM_DELLINK); >> >> + if (dev->features & NETIF_F_HW_SWITCH_OFFLOAD >> + && dev->netdev_ops->ndo_bridge_setlink) { >> + int ret = dev->netdev_ops->ndo_bridge_dellink(dev, nlh); > c&p issue, there should be check for dellink here. > >> + if (ret && ret != -EOPNOTSUPP) { >> + /* XXX Fix this in the future to rollback >> + * kernel settings and return error >> + */ >> + br_warn(p->br, "error offloading bridge attributes " >> + "on port %u(%s)\n", (unsigned int) p->port_no, >> + p->dev->name); >> + } >> + } >> + > > I agree with Scott that this code should be moved to rtnetlink.c > >> return err; >> } >> static int br_validate(struct nlattr *tb[], struct nlattr *data[]) >> -- >> 1.7.10.4 >> > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html