Re: [PATCH iproute2] bridge link: add option 'self'

[Roopa Prabhu <roopa@cumulusnetworks.com>]

On 12/4/14, 11:55 PM, Jiri Pirko wrote:
> Fri, Dec 05, 2014 at 03:27:16AM CET, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Currently self is set internally only if hwmode is set.
>> This makes it necessary for the hw to have a mode.
>> There is no hwmode really required to go to hardware. So, introduce
>> self for anybody who wants to target hardware.
>
> Signed-off line is missing.
>
> Other than that, the patch looks fine.
>
> Reviewed-by: Jiri Pirko <jiri@resnulli.us>
>
> Feel free to add my review line to the repost.

yep, thanks.
>
>
>> ---
>> bridge/link.c |    3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/bridge/link.c b/bridge/link.c
>> index 90d9e7f..2b86141 100644
>> --- a/bridge/link.c
>> +++ b/bridge/link.c
>> @@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
>> 					"\"veb\".\n");
>> 				exit(-1);
>> 			}
>> +		} else if (strcmp(*argv, "self") == 0) {
>> +			NEXT_ARG();
>> +			flags = BRIDGE_FLAGS_SELF;
>> 		} else {
>> 			usage();
>> 		}
>> -- 
>> 1.7.10.4
>>