* [PATCH iproute2] bridge link: add option 'self'
@ 2014-12-05 2:27 roopa
2014-12-05 6:52 ` Scott Feldman
2014-12-05 7:55 ` Jiri Pirko
0 siblings, 2 replies; 5+ messages in thread
From: roopa @ 2014-12-05 2:27 UTC (permalink / raw)
To: jiri, sfeldma, jhs, bcrl, tgraf, john.fastabend, stephen,
linville, nhorman, nicolas.dichtel, vyasevic, f.fainelli, buytenh,
aviadr
Cc: netdev, davem, shm, gospo, Roopa Prabhu
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Currently self is set internally only if hwmode is set.
This makes it necessary for the hw to have a mode.
There is no hwmode really required to go to hardware. So, introduce
self for anybody who wants to target hardware.
---
bridge/link.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bridge/link.c b/bridge/link.c
index 90d9e7f..2b86141 100644
--- a/bridge/link.c
+++ b/bridge/link.c
@@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
"\"veb\".\n");
exit(-1);
}
+ } else if (strcmp(*argv, "self") == 0) {
+ NEXT_ARG();
+ flags = BRIDGE_FLAGS_SELF;
} else {
usage();
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH iproute2] bridge link: add option 'self'
2014-12-05 2:27 [PATCH iproute2] bridge link: add option 'self' roopa
@ 2014-12-05 6:52 ` Scott Feldman
2014-12-05 7:04 ` Roopa Prabhu
2014-12-05 7:55 ` Jiri Pirko
1 sibling, 1 reply; 5+ messages in thread
From: Scott Feldman @ 2014-12-05 6:52 UTC (permalink / raw)
To: Roopa Prabhu
Cc: Jiří Pírko, Jamal Hadi Salim, Benjamin LaHaise,
Thomas Graf, john fastabend, stephen@networkplumber.org,
John Linville, nhorman@tuxdriver.com, Nicolas Dichtel,
vyasevic@redhat.com, Florian Fainelli, buytenh@wantstofly.org,
Aviad Raveh, Netdev, David S. Miller, shm, Andy Gospodarek
On Thu, Dec 4, 2014 at 6:27 PM, <roopa@cumulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Currently self is set internally only if hwmode is set.
> This makes it necessary for the hw to have a mode.
> There is no hwmode really required to go to hardware. So, introduce
> self for anybody who wants to target hardware.
Can you include unwinding the hwmode 'swdev' setting for
kernel/iproute2 in v2? With this "self" option, and your new
NETIF_F_HW_SWITCH_OFFLOAD flag, we don't need the hwmde 'swdev'.
> ---
> bridge/link.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/bridge/link.c b/bridge/link.c
> index 90d9e7f..2b86141 100644
> --- a/bridge/link.c
> +++ b/bridge/link.c
> @@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
> "\"veb\".\n");
> exit(-1);
> }
> + } else if (strcmp(*argv, "self") == 0) {
> + NEXT_ARG();
> + flags = BRIDGE_FLAGS_SELF;
> } else {
> usage();
> }
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH iproute2] bridge link: add option 'self'
2014-12-05 6:52 ` Scott Feldman
@ 2014-12-05 7:04 ` Roopa Prabhu
0 siblings, 0 replies; 5+ messages in thread
From: Roopa Prabhu @ 2014-12-05 7:04 UTC (permalink / raw)
To: Scott Feldman
Cc: Jiří Pírko, Jamal Hadi Salim, Benjamin LaHaise,
Thomas Graf, john fastabend, stephen@networkplumber.org,
John Linville, nhorman@tuxdriver.com, Nicolas Dichtel,
vyasevic@redhat.com, Florian Fainelli, buytenh@wantstofly.org,
Aviad Raveh, Netdev, David S. Miller, shm, Andy Gospodarek
On 12/4/14, 10:52 PM, Scott Feldman wrote:
> On Thu, Dec 4, 2014 at 6:27 PM, <roopa@cumulusnetworks.com> wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Currently self is set internally only if hwmode is set.
>> This makes it necessary for the hw to have a mode.
>> There is no hwmode really required to go to hardware. So, introduce
>> self for anybody who wants to target hardware.
> Can you include unwinding the hwmode 'swdev' setting for
> kernel/iproute2 in v2? With this "self" option, and your new
> NETIF_F_HW_SWITCH_OFFLOAD flag, we don't need the hwmde 'swdev'.
yep. will do. thanks
>> ---
>> bridge/link.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/bridge/link.c b/bridge/link.c
>> index 90d9e7f..2b86141 100644
>> --- a/bridge/link.c
>> +++ b/bridge/link.c
>> @@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
>> "\"veb\".\n");
>> exit(-1);
>> }
>> + } else if (strcmp(*argv, "self") == 0) {
>> + NEXT_ARG();
>> + flags = BRIDGE_FLAGS_SELF;
>> } else {
>> usage();
>> }
>> --
>> 1.7.10.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH iproute2] bridge link: add option 'self'
2014-12-05 2:27 [PATCH iproute2] bridge link: add option 'self' roopa
2014-12-05 6:52 ` Scott Feldman
@ 2014-12-05 7:55 ` Jiri Pirko
2014-12-05 13:46 ` Roopa Prabhu
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Pirko @ 2014-12-05 7:55 UTC (permalink / raw)
To: roopa
Cc: sfeldma, jhs, bcrl, tgraf, john.fastabend, stephen, linville,
nhorman, nicolas.dichtel, vyasevic, f.fainelli, buytenh, aviadr,
netdev, davem, shm, gospo
Fri, Dec 05, 2014 at 03:27:16AM CET, roopa@cumulusnetworks.com wrote:
>From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
>Currently self is set internally only if hwmode is set.
>This makes it necessary for the hw to have a mode.
>There is no hwmode really required to go to hardware. So, introduce
>self for anybody who wants to target hardware.
Signed-off line is missing.
Other than that, the patch looks fine.
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Feel free to add my review line to the repost.
>---
> bridge/link.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/bridge/link.c b/bridge/link.c
>index 90d9e7f..2b86141 100644
>--- a/bridge/link.c
>+++ b/bridge/link.c
>@@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
> "\"veb\".\n");
> exit(-1);
> }
>+ } else if (strcmp(*argv, "self") == 0) {
>+ NEXT_ARG();
>+ flags = BRIDGE_FLAGS_SELF;
> } else {
> usage();
> }
>--
>1.7.10.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH iproute2] bridge link: add option 'self'
2014-12-05 7:55 ` Jiri Pirko
@ 2014-12-05 13:46 ` Roopa Prabhu
0 siblings, 0 replies; 5+ messages in thread
From: Roopa Prabhu @ 2014-12-05 13:46 UTC (permalink / raw)
To: Jiri Pirko
Cc: sfeldma, jhs, bcrl, tgraf, john.fastabend, stephen, linville,
nhorman, nicolas.dichtel, vyasevic, f.fainelli, buytenh, aviadr,
netdev, davem, shm, gospo
On 12/4/14, 11:55 PM, Jiri Pirko wrote:
> Fri, Dec 05, 2014 at 03:27:16AM CET, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Currently self is set internally only if hwmode is set.
>> This makes it necessary for the hw to have a mode.
>> There is no hwmode really required to go to hardware. So, introduce
>> self for anybody who wants to target hardware.
>
> Signed-off line is missing.
>
> Other than that, the patch looks fine.
>
> Reviewed-by: Jiri Pirko <jiri@resnulli.us>
>
> Feel free to add my review line to the repost.
yep, thanks.
>
>
>> ---
>> bridge/link.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/bridge/link.c b/bridge/link.c
>> index 90d9e7f..2b86141 100644
>> --- a/bridge/link.c
>> +++ b/bridge/link.c
>> @@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
>> "\"veb\".\n");
>> exit(-1);
>> }
>> + } else if (strcmp(*argv, "self") == 0) {
>> + NEXT_ARG();
>> + flags = BRIDGE_FLAGS_SELF;
>> } else {
>> usage();
>> }
>> --
>> 1.7.10.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-05 13:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 2:27 [PATCH iproute2] bridge link: add option 'self' roopa
2014-12-05 6:52 ` Scott Feldman
2014-12-05 7:04 ` Roopa Prabhu
2014-12-05 7:55 ` Jiri Pirko
2014-12-05 13:46 ` Roopa Prabhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).