From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roopa Prabhu Subject: Re: [PATCH iproute2] bridge link: add option 'self' Date: Fri, 05 Dec 2014 05:46:25 -0800 Message-ID: <5481B731.3010706@cumulusnetworks.com> References: <1417746436-41023-1-git-send-email-roopa@cumulusnetworks.com> <20141205075559.GC1866@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: sfeldma@gmail.com, jhs@mojatatu.com, bcrl@kvack.org, tgraf@suug.ch, john.fastabend@gmail.com, stephen@networkplumber.org, linville@tuxdriver.com, nhorman@tuxdriver.com, nicolas.dichtel@6wind.com, vyasevic@redhat.com, f.fainelli@gmail.com, buytenh@wantstofly.org, aviadr@mellanox.com, netdev@vger.kernel.org, davem@davemloft.net, shm@cumulusnetworks.com, gospo@cumulusnetworks.com To: Jiri Pirko Return-path: Received: from ext3.cumulusnetworks.com ([198.211.106.187]:33027 "EHLO ext3.cumulusnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbaLENqj (ORCPT ); Fri, 5 Dec 2014 08:46:39 -0500 In-Reply-To: <20141205075559.GC1866@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On 12/4/14, 11:55 PM, Jiri Pirko wrote: > Fri, Dec 05, 2014 at 03:27:16AM CET, roopa@cumulusnetworks.com wrote: >> From: Roopa Prabhu >> >> Currently self is set internally only if hwmode is set. >> This makes it necessary for the hw to have a mode. >> There is no hwmode really required to go to hardware. So, introduce >> self for anybody who wants to target hardware. > > Signed-off line is missing. > > Other than that, the patch looks fine. > > Reviewed-by: Jiri Pirko > > Feel free to add my review line to the repost. yep, thanks. > > >> --- >> bridge/link.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/bridge/link.c b/bridge/link.c >> index 90d9e7f..2b86141 100644 >> --- a/bridge/link.c >> +++ b/bridge/link.c >> @@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv) >> "\"veb\".\n"); >> exit(-1); >> } >> + } else if (strcmp(*argv, "self") == 0) { >> + NEXT_ARG(); >> + flags = BRIDGE_FLAGS_SELF; >> } else { >> usage(); >> } >> -- >> 1.7.10.4 >>