[PATCH net-next v5 0/3] remove bridge mode BRIDGE_MODE_SWDEV

[PATCH net-next v5 0/3] remove bridge mode BRIDGE_MODE_SWDEV

[roopa]

From: Roopa Prabhu <roopa@cumulusnetworks.com>

BRIDGE_MODE_SWDEV was introduced to indicate switchdev offloads
for bridging from user space (In other words to call into the hw switch
port driver directly). But user can use existing BRIDGE_FLAGS_SELF
to call into the hw switch port driver today. swdev mode is not required
anymore. So, this patch removes it.

v4 - v5
    incorporate comments
    - Define BRIDGE_MODE_UNDEF to handle cases where mode is not defined
    - reverse the order of patches
    - include patch comments in all patches

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Roopa Prabhu (3):
  bridge: new mode flag to indicate mode 'undefined'
  rocker: remove swdev mode
  bridge: remove mode 'swdev'

 drivers/net/ethernet/rocker/rocker.c |   18 +-----------------
 include/uapi/linux/if_bridge.h       |    2 +-
 net/core/rtnetlink.c                 |   10 ++++++++--
 3 files changed, 10 insertions(+), 20 deletions(-)

-- 
1.7.10.4

Re: [PATCH net-next v5 0/3] remove bridge mode BRIDGE_MODE_SWDEV

[Scott Feldman]

Roopa, thanks for fixing this.  I'm a little lost on status of the
iproute2 patches related to this change and earlier changes.  Would
you and Jiri respin one set of iproute2 patches that gets us the final
answer?  It was getting a little messy with patches on top of
yet-to-be-accepted patches.  Thanks.

On Mon, Dec 8, 2014 at 2:04 PM,  <roopa@cumulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> BRIDGE_MODE_SWDEV was introduced to indicate switchdev offloads
> for bridging from user space (In other words to call into the hw switch
> port driver directly). But user can use existing BRIDGE_FLAGS_SELF
> to call into the hw switch port driver today. swdev mode is not required
> anymore. So, this patch removes it.
>
> v4 - v5
>     incorporate comments
>     - Define BRIDGE_MODE_UNDEF to handle cases where mode is not defined
>     - reverse the order of patches
>     - include patch comments in all patches
>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Roopa Prabhu (3):
>   bridge: new mode flag to indicate mode 'undefined'
>   rocker: remove swdev mode
>   bridge: remove mode 'swdev'
>
>  drivers/net/ethernet/rocker/rocker.c |   18 +-----------------
>  include/uapi/linux/if_bridge.h       |    2 +-
>  net/core/rtnetlink.c                 |   10 ++++++++--
>  3 files changed, 10 insertions(+), 20 deletions(-)
>
> --
> 1.7.10.4
>

Re: [PATCH net-next v5 0/3] remove bridge mode BRIDGE_MODE_SWDEV

[Roopa Prabhu]

On 12/8/14, 2:49 PM, Scott Feldman wrote:
> Roopa, thanks for fixing this.  I'm a little lost on status of the
> iproute2 patches related to this change and earlier changes.  Would
> you and Jiri respin one set of iproute2 patches that gets us the final
> answer?  It was getting a little messy with patches on top of
> yet-to-be-accepted patches.  Thanks.
scott, the iproute2 v3 patch was the last (hopefully final) patch and 
jiri and you signed-off on that
Its here:
http://patchwork.ozlabs.org/patch/418350/

Thanks for the review.

>
> On Mon, Dec 8, 2014 at 2:04 PM,  <roopa@cumulusnetworks.com> wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> BRIDGE_MODE_SWDEV was introduced to indicate switchdev offloads
>> for bridging from user space (In other words to call into the hw switch
>> port driver directly). But user can use existing BRIDGE_FLAGS_SELF
>> to call into the hw switch port driver today. swdev mode is not required
>> anymore. So, this patch removes it.
>>
>> v4 - v5
>>      incorporate comments
>>      - Define BRIDGE_MODE_UNDEF to handle cases where mode is not defined
>>      - reverse the order of patches
>>      - include patch comments in all patches
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Roopa Prabhu (3):
>>    bridge: new mode flag to indicate mode 'undefined'
>>    rocker: remove swdev mode
>>    bridge: remove mode 'swdev'
>>
>>   drivers/net/ethernet/rocker/rocker.c |   18 +-----------------
>>   include/uapi/linux/if_bridge.h       |    2 +-
>>   net/core/rtnetlink.c                 |   10 ++++++++--
>>   3 files changed, 10 insertions(+), 20 deletions(-)
>>
>> --
>> 1.7.10.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v5 0/3] remove bridge mode BRIDGE_MODE_SWDEV

[David Miller]

From: roopa@cumulusnetworks.com
Date: Mon,  8 Dec 2014 14:04:18 -0800

> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> BRIDGE_MODE_SWDEV was introduced to indicate switchdev offloads
> for bridging from user space (In other words to call into the hw switch
> port driver directly). But user can use existing BRIDGE_FLAGS_SELF
> to call into the hw switch port driver today. swdev mode is not required
> anymore. So, this patch removes it.
> 
> v4 - v5
>     incorporate comments
>     - Define BRIDGE_MODE_UNDEF to handle cases where mode is not defined
>     - reverse the order of patches
>     - include patch comments in all patches
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Series applied, thanks.