* [PATCH net v6 7/7] libcxgbi: free skb after debug prints
@ 2014-12-10 16:25 Karen Xie
2014-12-10 19:38 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Karen Xie @ 2014-12-10 16:25 UTC (permalink / raw)
To: linux-scsi, netdev
Cc: kxie, hariprasad, anish, hch, James.Bottomley, michaelc, davem
[PATCH net v6 7/7] libcxgbi: free skb after debug prints
From: Karen Xie <kxie@chelsio.com>
The debug print was accessing the skb after it was freed.
Signed-off-by: Karen Xie <kxie@chelsio.com>
---
drivers/scsi/cxgbi/libcxgbi.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 7da59c3..eb58afc 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -2294,10 +2294,12 @@ int cxgbi_conn_xmit_pdu(struct iscsi_task *task)
return err;
}
- kfree_skb(skb);
log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX,
"itt 0x%x, skb 0x%p, len %u/%u, xmit err %d.\n",
task->itt, skb, skb->len, skb->data_len, err);
+
+ kfree_skb(skb);
+
iscsi_conn_printk(KERN_ERR, task->conn, "xmit err %d.\n", err);
iscsi_conn_failure(task->conn, ISCSI_ERR_XMIT_FAILED);
return err;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
2014-12-10 16:25 [PATCH net v6 7/7] libcxgbi: free skb after debug prints Karen Xie
@ 2014-12-10 19:38 ` Sergei Shtylyov
2014-12-10 20:26 ` Karen Xie
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2014-12-10 19:38 UTC (permalink / raw)
To: Karen Xie, linux-scsi, netdev
Cc: hariprasad, anish, hch, James.Bottomley, michaelc, davem
Hello.
On 12/10/2014 07:25 PM, Karen Xie wrote:
> [PATCH net v6 7/7] libcxgbi: free skb after debug prints
Please, do not duplicate the subject in the changelog -- DaveM would have
to edit it out by hand.
> From: Karen Xie <kxie@chelsio.com>
> The debug print was accessing the skb after it was freed.
> Signed-off-by: Karen Xie <kxie@chelsio.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
2014-12-10 19:38 ` Sergei Shtylyov
@ 2014-12-10 20:26 ` Karen Xie
2014-12-10 20:32 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Karen Xie @ 2014-12-10 20:26 UTC (permalink / raw)
To: Sergei Shtylyov, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org
Cc: Hariprasad S, Anish Bhatt, hch@infradead.org,
James.Bottomley@HansenPartnership.com, michaelc@cs.wisc.edu,
davem@davemloft.net
Thanks, v7 has been submitted to address your comment. Please review.
________________________________________
From: Sergei Shtylyov [sergei.shtylyov@cogentembedded.com]
Sent: Wednesday, December 10, 2014 11:38 AM
To: Karen Xie; linux-scsi@vger.kernel.org; netdev@vger.kernel.org
Cc: Hariprasad S; Anish Bhatt; hch@infradead.org; James.Bottomley@HansenPartnership.com; michaelc@cs.wisc.edu; davem@davemloft.net
Subject: Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
Hello.
On 12/10/2014 07:25 PM, Karen Xie wrote:
> [PATCH net v6 7/7] libcxgbi: free skb after debug prints
Please, do not duplicate the subject in the changelog -- DaveM would have
to edit it out by hand.
> From: Karen Xie <kxie@chelsio.com>
> The debug print was accessing the skb after it was freed.
> Signed-off-by: Karen Xie <kxie@chelsio.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
2014-12-10 20:26 ` Karen Xie
@ 2014-12-10 20:32 ` David Miller
2014-12-10 21:02 ` Karen Xie
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2014-12-10 20:32 UTC (permalink / raw)
To: kxie
Cc: sergei.shtylyov, linux-scsi, netdev, hariprasad, anish, hch,
James.Bottomley, michaelc
From: Karen Xie <kxie@chelsio.com>
Date: Wed, 10 Dec 2014 20:26:59 +0000
> Thanks, v7 has been submitted to address your comment. Please review.
Sorry, you did not actually address his comments.
He said to not duplicate your Subject lines in your message bodies,
and you did not fix that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
2014-12-10 20:32 ` David Miller
@ 2014-12-10 21:02 ` Karen Xie
2014-12-10 21:04 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Karen Xie @ 2014-12-10 21:02 UTC (permalink / raw)
To: David Miller
Cc: sergei.shtylyov@cogentembedded.com, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org, Hariprasad S, Anish Bhatt,
hch@infradead.org, James.Bottomley@HansenPartnership.com,
michaelc@cs.wisc.edu
Sorry, misread the comment, will resubmit. Thanks.
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, December 10, 2014 12:33 PM
To: Karen Xie
Cc: sergei.shtylyov@cogentembedded.com; linux-scsi@vger.kernel.org; netdev@vger.kernel.org; Hariprasad S; Anish Bhatt; hch@infradead.org; James.Bottomley@HansenPartnership.com; michaelc@cs.wisc.edu
Subject: Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
From: Karen Xie <kxie@chelsio.com>
Date: Wed, 10 Dec 2014 20:26:59 +0000
> Thanks, v7 has been submitted to address your comment. Please review.
Sorry, you did not actually address his comments.
He said to not duplicate your Subject lines in your message bodies, and you did not fix that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints
2014-12-10 21:02 ` Karen Xie
@ 2014-12-10 21:04 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-12-10 21:04 UTC (permalink / raw)
To: kxie
Cc: sergei.shtylyov, linux-scsi, netdev, hariprasad, anish, hch,
James.Bottomley, michaelc
From: Karen Xie <kxie@chelsio.com>
Date: Wed, 10 Dec 2014 21:02:34 +0000
> Sorry, misread the comment, will resubmit. Thanks.
Please do not top-post.
Quote the relevant material, then provide your own content
after the quoted material, not before.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-10 21:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10 16:25 [PATCH net v6 7/7] libcxgbi: free skb after debug prints Karen Xie
2014-12-10 19:38 ` Sergei Shtylyov
2014-12-10 20:26 ` Karen Xie
2014-12-10 20:32 ` David Miller
2014-12-10 21:02 ` Karen Xie
2014-12-10 21:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).