From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sathya Perla <Sathya.Perla@Emulex.Com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] be2net: Export tunnel offloads only when a VxLAN tunnel is created
Date: Thu, 11 Dec 2014 17:35:38 +0300 [thread overview]
Message-ID: <5489ABBA.9080102@cogentembedded.com> (raw)
In-Reply-To: <CF9D1877D81D214CB0CA0669EFAE020C68D24ADD@CMEXMB1.ad.emulex.com>
Hello.
On 12/11/2014 10:24 AM, Sathya Perla wrote:
>>> + netdev->hw_enc_features |= (NETIF_F_IP_CSUM |
>> NETIF_F_IPV6_CSUM |
>>> + NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_GSO_UDP_TUNNEL);
>> Please indent this properly:
>> netdev->hw_enc_features |= (NETIF_F_IP_CSUM |
>> NETIF_F_IPV6_CSUM |
>> NETIF_F_TSO | NETIF_F_TSO6 |
>> NETIF_F_GSO_UDP_TUNNEL);
> Oops, checkpatch didn't seem to catch this...will fix it up and send out a v2 right away...
> thanks!
Parens are not needed here as well.
WBR, Sergei
prev parent reply other threads:[~2014-12-11 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 9:56 [PATCH net] be2net: Export tunnel offloads only when a VxLAN tunnel is created Sathya Perla
2014-12-10 19:53 ` David Miller
2014-12-11 7:24 ` Sathya Perla
2014-12-11 14:35 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5489ABBA.9080102@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Sathya.Perla@Emulex.Com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).