From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, jim.epost@gmail.com
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet
Date: Thu, 11 Dec 2014 21:09:01 -0800 [thread overview]
Message-ID: <548A786D.2060201@gmail.com> (raw)
In-Reply-To: <20141211.142220.610076934853342634.davem@davemloft.net>
Le 11/12/2014 11:22, David Miller a écrit :
> From: Jim Davis <jim.epost@gmail.com> Date: Wed, 10 Dec 2014
> 09:10:45 -0700
>
>> Building with the attached random configuration file,
>>
>> ERROR: "fixed_phy_register"
>> [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>
> Florian, I don't understand why FIXED_PHY is only selected in
> Kconfig if the driver is statically built into the kernel.
>
> That makes no sense at all, you should need that module regardless
> of how the driver itself is enabled.
AFAIR this was introduced to silence a warning you reported:
"I think you need to work on the Kconfig dependencies a little bit more.
I have BCMGENET specified as modular, which absolutely should work. Yet
Kconfig complains.
warning: (BCMGENET) selects FIXED_PHY which has unmet direct
dependencies (NETDEVICES && PHYLIB=y)"
but I agree, this makes no sense, we should select FIXED_PHY
unconditionnally, will send you patches tomorrow to fix that.
>
> Can't we just remove the "XXX=y" in all of those silly:
>
> select FIXED_PHY if XXX=y
>
> expressions?
>
> There are three such cases right now:
>
> drivers/net/dsa/Kconfig: select FIXED_PHY if NET_DSA_BCM_SF2=y
> drivers/net/ethernet/broadcom/Kconfig: select FIXED_PHY if
> BCMGENET=y drivers/net/ethernet/broadcom/Kconfig: select FIXED_PHY
> if SYSTEMPORT=y
>
--
Florian
next prev parent reply other threads:[~2014-12-12 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 16:10 randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet Jim Davis
2014-12-11 19:22 ` David Miller
2014-12-12 5:09 ` Florian Fainelli [this message]
2014-12-12 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548A786D.2060201@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).