From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>, David Miller <davem@davemloft.net>
Cc: mitsuhiro.kimura.kc@renesas.com, netdev@vger.kernel.org
Subject: Re: errors in alignment changes..
Date: Fri, 12 Dec 2014 15:00:16 +0300 [thread overview]
Message-ID: <548AD8D0.4040207@cogentembedded.com> (raw)
In-Reply-To: <20141212043010.GC17790@verge.net.au>
Hello.
On 12/12/2014 7:30 AM, Simon Horman wrote:
>> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Date: Thu, 11 Dec 2014 01:08:07 +0300
>>> I guess we can just do:
>>> rxdesc->addr = dma_map_single(...);
>> Best not to leave a potentially invalid DMA address in a
>> receive descriptor the chip can potentially fetch and
>> look at.
>> That's why I said to put it into a local variable and
>> check for errors first.
> Hi Dave,
> this patch ending up in net is partially my fault.
> Sergei, do you have time to address David's concerns in relation to this
> patch?
No, I probably don't.
> If not I would like to suggest reverting it for now.
Why? The patch does what it was intended for. Getting rid of
virt_to_phys() calls is a separate issue, IMO.
WBR, Sergei
next prev parent reply other threads:[~2014-12-12 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:52 errors in alignment changes David Miller
2014-12-10 22:08 ` Sergei Shtylyov
2014-12-11 1:42 ` David Miller
2014-12-12 4:30 ` Simon Horman
2014-12-12 12:00 ` Sergei Shtylyov [this message]
2014-12-16 5:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548AD8D0.4040207@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).