* [PATCH] net: phy: export fixed_phy_register()
@ 2014-12-12 4:03 Mark Salter
2014-12-12 12:31 ` Florian Fainelli
2014-12-12 16:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mark Salter @ 2014-12-12 4:03 UTC (permalink / raw)
To: Florian Fainelli; +Cc: netdev, linux-kernel, davem, Mark Salter
When building the bcmgenet driver as module, I get:
ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device
tree") which added a call to fixed_phy_register. But fixed_phy_register
needs to be exported if used from a module.
Signed-off-by: Mark Salter <msalter@redhat.com>
---
drivers/net/phy/fixed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
index 47872caa..3ad0e6e 100644
--- a/drivers/net/phy/fixed.c
+++ b/drivers/net/phy/fixed.c
@@ -274,6 +274,7 @@ struct phy_device *fixed_phy_register(unsigned int irq,
return phy;
}
+EXPORT_SYMBOL_GPL(fixed_phy_register);
static int __init fixed_mdio_bus_init(void)
{
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: export fixed_phy_register()
2014-12-12 4:03 [PATCH] net: phy: export fixed_phy_register() Mark Salter
@ 2014-12-12 12:31 ` Florian Fainelli
2014-12-12 16:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2014-12-12 12:31 UTC (permalink / raw)
To: Mark Salter; +Cc: netdev, linux-kernel, davem
Le 11/12/2014 20:03, Mark Salter a écrit :
> When building the bcmgenet driver as module, I get:
>
> ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>
> commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device
> tree") which added a call to fixed_phy_register. But fixed_phy_register
> needs to be exported if used from a module.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
I will have to rework the GENET/SYSTEMPORT/SF2 dependencies anyway, thanks!
> ---
> drivers/net/phy/fixed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
> index 47872caa..3ad0e6e 100644
> --- a/drivers/net/phy/fixed.c
> +++ b/drivers/net/phy/fixed.c
> @@ -274,6 +274,7 @@ struct phy_device *fixed_phy_register(unsigned int irq,
>
> return phy;
> }
> +EXPORT_SYMBOL_GPL(fixed_phy_register);
>
> static int __init fixed_mdio_bus_init(void)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: export fixed_phy_register()
2014-12-12 4:03 [PATCH] net: phy: export fixed_phy_register() Mark Salter
2014-12-12 12:31 ` Florian Fainelli
@ 2014-12-12 16:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-12-12 16:01 UTC (permalink / raw)
To: msalter; +Cc: f.fainelli, netdev, linux-kernel
From: Mark Salter <msalter@redhat.com>
Date: Thu, 11 Dec 2014 23:03:26 -0500
> When building the bcmgenet driver as module, I get:
>
> ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>
> commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device
> tree") which added a call to fixed_phy_register. But fixed_phy_register
> needs to be exported if used from a module.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
APplied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-12 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-12 4:03 [PATCH] net: phy: export fixed_phy_register() Mark Salter
2014-12-12 12:31 ` Florian Fainelli
2014-12-12 16:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).