From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Zhu Yanjun <zyjzyj2000@gmail.com>, netdev@vger.kernel.org, w@1wt.eu
Cc: Zhu Yanjun <Yanjun.Zhu@windriver.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked
Date: Mon, 15 Dec 2014 15:01:48 +0300 [thread overview]
Message-ID: <548ECDAC.90207@cogentembedded.com> (raw)
In-Reply-To: <1418632754-16698-4-git-send-email-Yanjun.Zhu@windriver.com>
Hello.
On 12/15/2014 11:39 AM, Zhu Yanjun wrote:
> 2.6.x kernels require a similar logic change as commit b7d6e335
> [e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked]
> introduces for newer kernels.
Hm, so is this patch to 2.6.x-stable kernels or a recent kernel?
If the former, you should follow the rules in
Documentation/stable_kernel_rules.txt.
> When PHY reset is intentionally blocked on 82577/8/9, do not toggle the
> LANPHYPC value bit (essentially performing a hard power reset of the
> device) otherwise the PHY can be put into an unknown state.
> Cleanup whitespace in the same function.
> [yanjun.zhu: whitespace remains unchanged]
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
So, is this your patch, or Bruce's? If the latter, you should add:
From: Bruce Allan <bruce.w.allan@intel.com>
at the start of the change log.
> Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
WBR, Sergei
next prev parent reply other threads:[~2014-12-15 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 8:39 [PATCH 0/5] e1000e: fix nic not boot after rebooting Zhu Yanjun
2014-12-15 8:39 ` [PATCH 1/5] e1000e: reset MAC-PHY interconnect on 82577/82578 Zhu Yanjun
2014-12-15 8:39 ` [PATCH 2/5] e1000e: workaround EEPROM configuration change on 82579 on kernel 2.6.x Zhu Yanjun
2014-12-15 8:39 ` [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked Zhu Yanjun
2014-12-15 12:01 ` Sergei Shtylyov [this message]
2014-12-15 12:16 ` Willy Tarreau
2014-12-15 13:21 ` Zhu, Yanjun
2014-12-15 13:33 ` Willy Tarreau
2014-12-16 2:08 ` yzhu1
2014-12-15 8:39 ` [PATCH 4/5] e1000e: update workaround for 82579 intermittently disabled during S0->Sx Zhu Yanjun
2014-12-15 8:39 ` [PATCH 5/5] e1000e: cleanup use of check_reset_block function pointer Zhu Yanjun
2014-12-15 8:48 ` [PATCH 0/5] e1000e: fix nic not boot after rebooting Willy Tarreau
-- strict thread matches above, loose matches on Subject: below --
2014-12-16 10:28 [PATCH V2 " Zhu Yanjun
2014-12-16 10:28 ` [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548ECDAC.90207@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Yanjun.Zhu@windriver.com \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).