From: Josef Bacik <jbacik@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Laurent Chavey <chavey@google.com>,
Yuchung Cheng <ycheng@google.com>
Cc: Martin KaFai Lau <kafai@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Steven Rostedt <rostedt@goodmis.org>,
Lawrence Brakmo <brakmo@fb.com>, Kernel Team <Kernel-team@fb.com>
Subject: Re: [RFC PATCH net-next 0/5] tcp: TCP tracer
Date: Mon, 15 Dec 2014 11:42:10 -0500 [thread overview]
Message-ID: <548F0F62.7080704@fb.com> (raw)
In-Reply-To: <1418659395.9773.13.camel@edumazet-glaptop2.roam.corp.google.com>
On 12/15/2014 11:03 AM, Eric Dumazet wrote:
> On Sun, 2014-12-14 at 22:55 -0800, Alexei Starovoitov wrote:
>
>> I think patches 1 and 3 are good additions, since they establish
>> few permanent points of instrumentation in tcp stack.
>> Patches 4-5 look more like use cases of tracepoints established
>> before. They may feel like simple additions and, no doubt,
>> they are useful, but since they expose things via tracing
>> infra they become part of api and cannot be changed later,
>> when more stats would be needed.
>> I think systemtap like scripting on top of patches 1 and 3
>> should solve your use case ?
>> Also, have you looked at recent eBPF work?
>> Though it's not completely ready yet, soon it should
>> be able to do the same stats collection as you have
>> in 4/5 without adding permanent pieces to the kernel.
>
> So it looks like web10g like interfaces are very often requested by
> various teams.
>
> And we have many different views on how to hack this. I am astonished by
> number of hacks I saw about this stuff going on.
>
> What about a clean way, extending current TCP_INFO, which is both
> available as a getsockopt() for socket owners and ss/iproute2
> information for 'external entities'
>
> If we consider web10g info needed, then adding a ftrace/eBPF like
> interface is simply yet another piece of code we need to maintain,
> and the argument of 'this should cost nothing if not activated' is
> nonsense since major players need to constantly monitor TCP metrics and
> behavior.
>
> It seems both FaceBook and Google are working on a subset of web10g.
>
> I suggest we meet together and establish a common ground, preferably
> after Christmas holidays.
>
We've set up something for exactly this case at the end of January but
have yet to get a response from Google. If any of the Google people
cc'ed (or really anybody, its not a strictly FB/Google thing) is
interested please email me directly and I'll send you the details, we
will be meeting face to face in the bay area at the end of January. Thanks,
Josef
next prev parent reply other threads:[~2014-12-15 16:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 6:55 [RFC PATCH net-next 0/5] tcp: TCP tracer Alexei Starovoitov
2014-12-15 16:03 ` Eric Dumazet
2014-12-15 16:08 ` Blake Matheny
2014-12-15 19:56 ` Yuchung Cheng
2014-12-17 20:45 ` rapier
2014-12-16 18:28 ` Martin Lau
2014-12-15 16:42 ` Josef Bacik [this message]
2014-12-15 22:01 ` Tom Herbert
2014-12-15 22:17 ` rapier
2014-12-15 22:29 ` Steven Rostedt
2014-12-15 23:28 ` Jamal Hadi Salim
2014-12-15 23:40 ` Eric Dumazet
2014-12-16 22:40 ` Jason Baron
2014-12-16 22:45 ` David Miller
2014-12-16 22:50 ` Hannes Frederic Sowa
2014-12-17 15:07 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2014-12-17 20:42 Alexei Starovoitov
2014-12-17 20:56 ` David Ahern
2014-12-17 21:24 ` Arnaldo Carvalho de Melo
2014-12-17 21:19 ` Arnaldo Carvalho de Melo
2014-12-17 17:14 Alexei Starovoitov
2014-12-17 19:51 ` Arnaldo Carvalho de Melo
2014-12-17 3:06 Alexei Starovoitov
2014-12-17 21:42 ` Josef Bacik
2014-12-18 23:43 ` Lawrence Brakmo
2014-12-19 1:42 ` Yuchung Cheng
2014-12-17 0:15 Alexei Starovoitov
2014-12-17 1:30 ` Martin Lau
2014-12-15 1:56 Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F0F62.7080704@fb.com \
--to=jbacik@fb.com \
--cc=Kernel-team@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=brakmo@fb.com \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).