From: yzhu1 <Yanjun.Zhu@windriver.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ALLAN, BRUCE" <bruce.w.allan@intel.com>,
"KIRSHER, JEFFREY" <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked
Date: Tue, 16 Dec 2014 10:08:10 +0800 [thread overview]
Message-ID: <548F940A.4050409@windriver.com> (raw)
In-Reply-To: <20141215133335.GC28701@1wt.eu>
Hi, Willy
Thanks for your reply.
I will fix it and send V2.
Best Regards!
Zhu Yanjun
On 12/15/2014 09:33 PM, Willy Tarreau wrote:
> On Mon, Dec 15, 2014 at 01:21:43PM +0000, Zhu, Yanjun wrote:
>> Hi, Willy
>>
>> Thanks for your reply.
>>
>> This patch "[PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked" exists in tag v3.1.
>>
>> Please follow these steps, this patch can be found:
>>
>> 1. git checkout -f v3.1
>>
>> 2. git log -p drivers/net/e1000e/ich8lan.c
>>
>> 3. search "b7d6e335"
>>
>> Then we will find this patch.
> Ah it's because you truncated the commit ID from the right instead of from
> the left. Truncated commit IDs are valid from the left, not from the right.
> In your case, the commit is 6cc7aaed70c96c3933fbacbad582fc79b7d6e335
> ("e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked"), so
> the truncated ID is 6cc7aae, not b7d6e335. It's important to fix that in
> your commit messages so that a "git show" works correctly (it failed for me
> for this precise reason).
>
> Thanks,
> Willy
>
next prev parent reply other threads:[~2014-12-16 2:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 8:39 [PATCH 0/5] e1000e: fix nic not boot after rebooting Zhu Yanjun
2014-12-15 8:39 ` [PATCH 1/5] e1000e: reset MAC-PHY interconnect on 82577/82578 Zhu Yanjun
2014-12-15 8:39 ` [PATCH 2/5] e1000e: workaround EEPROM configuration change on 82579 on kernel 2.6.x Zhu Yanjun
2014-12-15 8:39 ` [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked Zhu Yanjun
2014-12-15 12:01 ` Sergei Shtylyov
2014-12-15 12:16 ` Willy Tarreau
2014-12-15 13:21 ` Zhu, Yanjun
2014-12-15 13:33 ` Willy Tarreau
2014-12-16 2:08 ` yzhu1 [this message]
2014-12-15 8:39 ` [PATCH 4/5] e1000e: update workaround for 82579 intermittently disabled during S0->Sx Zhu Yanjun
2014-12-15 8:39 ` [PATCH 5/5] e1000e: cleanup use of check_reset_block function pointer Zhu Yanjun
2014-12-15 8:48 ` [PATCH 0/5] e1000e: fix nic not boot after rebooting Willy Tarreau
-- strict thread matches above, loose matches on Subject: below --
2014-12-16 10:28 [PATCH V2 " Zhu Yanjun
2014-12-16 10:28 ` [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F940A.4050409@windriver.com \
--to=yanjun.zhu@windriver.com \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=w@1wt.eu \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).