From: Oliver Neukum <oneukum@suse.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] net: asix: init ASIX AX88772B MAC from EEPROM
Date: Tue, 18 Dec 2012 14:11:51 +0100 [thread overview]
Message-ID: <5491619.g500gaSnsh@linux-lqwf.site> (raw)
In-Reply-To: <1355832626-3034-1-git-send-email-dev@lynxeye.de>
On Tuesday 18 December 2012 13:10:25 Lucas Stach wrote:
> diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
> index 9bbeabf..8e9516f 100644
> --- a/include/linux/usb/usbnet.h
> +++ b/include/linux/usb/usbnet.h
> @@ -106,6 +106,7 @@ struct driver_info {
> */
> #define FLAG_MULTI_PACKET 0x2000
> #define FLAG_RX_ASSEMBLE 0x4000 /* rx packets may span >1 frames */
> +#define FLAG_EEPROM_MAC 0x8000 /* initialize device MAC from eeprom */
Hi,
this looks sensible, but
why are you adding a flag unused in usbnet to usbnet.h?
Regards
Oliver
next prev parent reply other threads:[~2012-12-18 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 12:10 [PATCH 1/2] net: asix: init ASIX AX88772B MAC from EEPROM Lucas Stach
[not found] ` <1355832626-3034-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-18 12:10 ` [PATCH 2/2] net: asix: handle packets crossing URB boundaries Lucas Stach
2012-12-18 13:42 ` Oliver Neukum
2012-12-18 13:11 ` Oliver Neukum [this message]
2012-12-18 13:24 ` [PATCH 1/2] net: asix: init ASIX AX88772B MAC from EEPROM Lucas Stach
2012-12-18 13:33 ` Oliver Neukum
2012-12-18 13:38 ` Lucas Stach
2012-12-18 13:56 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5491619.g500gaSnsh@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=dev@lynxeye.de \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).