From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [iproute2] tc: Show classes more hierarchically] Date: Thu, 18 Dec 2014 10:46:06 -0200 Message-ID: <5492CC8E.6050108@gmail.com> References: <20141215224851.GB6734@angus-think.lan> <54907619.5080508@gmail.com> <20141217115535.3f5198d2@urahara> <20141217235627.GA2149@angus-think.lan> <54923434.3030209@gmail.com> <20141218031257.GA19527@angus-think.lan> <5492C7FD.8060603@gmail.com> <20141218122329.GA31878@angus-think.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , netdev@vger.kernel.org To: Vadim Kochan Return-path: Received: from mail-qa0-f47.google.com ([209.85.216.47]:33291 "EHLO mail-qa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbaLRMqN (ORCPT ); Thu, 18 Dec 2014 07:46:13 -0500 Received: by mail-qa0-f47.google.com with SMTP id s7so720188qap.6 for ; Thu, 18 Dec 2014 04:46:12 -0800 (PST) In-Reply-To: <20141218122329.GA31878@angus-think.lan> Sender: netdev-owner@vger.kernel.org List-ID: On 18-12-2014 10:23, Vadim Kochan wrote: > On Thu, Dec 18, 2014 at 10:26:37AM -0200, Marcelo Ricardo Leitner wrote: >>> +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | * Send 100 pkts ... >>> | * Rate 10mbit ... >>> +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>> | | * Send 100 pkts ... >>> | | * Rate 10mbit ... >>> | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | | * Send 100 pkts ... >>> | | | * Rate 10mbit ... >>> | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | | | * Send 100 pkts ... >>> | | | | * Rate 10mbit ... >> ^ these are confusing IMHO, rest looks good to me >> >> Marcelo >> > > > Yes, just fixed it to : Cool > +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > | > +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | | > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > | > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > * Send 100 pkts ... > * Rate 10mbit ... > > I am not sure about the better format to print stats - use '*' or '>' as > prefix, '*' - seems better ? TBH I don't think we need one in there. It's already linked to the items due to the tree on them. If you just align them to start right where the the first word after the ')' begins, it would be good. Like: | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | | Send 100 pkts ... | | | Rate 10mbit ... | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | Send 100 pkts ... | | | Rate 10mbit ... | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b But I don't know how large this will get.. Yet I don't mind having one marker in there. Let's see what others think about it. Regards, Marcelo