* [iproute2] tc: Show classes more hierarchically]
@ 2014-12-15 22:48 vadim4j
2014-12-16 13:49 ` Eric Dumazet
2014-12-16 18:12 ` Marcelo Ricardo Leitner
0 siblings, 2 replies; 16+ messages in thread
From: vadim4j @ 2014-12-15 22:48 UTC (permalink / raw)
To: netdev; +Cc: vadim4j
Hi All,
I am playing with showing classes in more hierarchically format and I
have some code and example of output from my TC looks like:
# tc/tc -t class show dev tap0
\---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
\---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
which in standart output mode it looks like:
# tc/tc class show dev tap0
class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
So I'd like to ask if it might be useful for the TC users (may be
better format ?) to have this ?
Thanks,
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-15 22:48 [iproute2] tc: Show classes more hierarchically] vadim4j @ 2014-12-16 13:49 ` Eric Dumazet 2014-12-16 18:12 ` Marcelo Ricardo Leitner 1 sibling, 0 replies; 16+ messages in thread From: Eric Dumazet @ 2014-12-16 13:49 UTC (permalink / raw) To: vadim4j; +Cc: netdev On Tue, 2014-12-16 at 00:48 +0200, vadim4j@gmail.com wrote: > Hi All, > > I am playing with showing classes in more hierarchically format and I > have some code and example of output from my TC looks like: > > # tc/tc -t class show dev tap0 > > \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > So I'd like to ask if it might be useful for the TC users (may be > better format ?) to have this ? Sure, this seems interesting, thanks ! ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-15 22:48 [iproute2] tc: Show classes more hierarchically] vadim4j 2014-12-16 13:49 ` Eric Dumazet @ 2014-12-16 18:12 ` Marcelo Ricardo Leitner 2014-12-17 19:55 ` Stephen Hemminger 1 sibling, 1 reply; 16+ messages in thread From: Marcelo Ricardo Leitner @ 2014-12-16 18:12 UTC (permalink / raw) To: vadim4j, netdev On 15-12-2014 20:48, vadim4j@gmail.com wrote: > Hi All, > > I am playing with showing classes in more hierarchically format and I > have some code and example of output from my TC looks like: > > # tc/tc -t class show dev tap0 > > \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > which in standart output mode it looks like: > > # tc/tc class show dev tap0 > > class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > So I'd like to ask if it might be useful for the TC users (may be > better format ?) to have this ? Good idea! It already looks good, but what about: |-- 1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | |-- 1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | |-- 1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | '-- 1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b |-- 1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b ... just another idea.. Thanks. Marcelo ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-16 18:12 ` Marcelo Ricardo Leitner @ 2014-12-17 19:55 ` Stephen Hemminger 2014-12-17 23:56 ` Vadim Kochan 0 siblings, 1 reply; 16+ messages in thread From: Stephen Hemminger @ 2014-12-17 19:55 UTC (permalink / raw) To: Marcelo Ricardo Leitner; +Cc: vadim4j, netdev On Tue, 16 Dec 2014 16:12:41 -0200 Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote: > On 15-12-2014 20:48, vadim4j@gmail.com wrote: > > Hi All, > > > > I am playing with showing classes in more hierarchically format and I > > have some code and example of output from my TC looks like: > > > > # tc/tc -t class show dev tap0 > > > > \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > > > > which in standart output mode it looks like: > > > > # tc/tc class show dev tap0 > > > > class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > > So I'd like to ask if it might be useful for the TC users (may be > > better format ?) to have this ? > > Good idea! It already looks good, but what about: > > |-- 1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | |-- 1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | |-- 1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | '-- 1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > |-- 1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > ... > > just another idea.. > > Thanks. > Marcelo There are several places that also print tree format, hopefully there would be reusable code (lspci, tree, ps). ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-17 19:55 ` Stephen Hemminger @ 2014-12-17 23:56 ` Vadim Kochan 2014-12-18 1:56 ` Marcelo Ricardo Leitner 0 siblings, 1 reply; 16+ messages in thread From: Vadim Kochan @ 2014-12-17 23:56 UTC (permalink / raw) To: Stephen Hemminger; +Cc: Marcelo Ricardo Leitner, vadim4j, netdev On Wed, Dec 17, 2014 at 11:55:35AM -0800, Stephen Hemminger wrote: > On Tue, 16 Dec 2014 16:12:41 -0200 > Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote: > > > On 15-12-2014 20:48, vadim4j@gmail.com wrote: > > > Hi All, > > > > > > I am playing with showing classes in more hierarchically format and I > > > have some code and example of output from my TC looks like: > > > > > > # tc/tc -t class show dev tap0 > > > > > > \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > > > > > > > which in standart output mode it looks like: > > > > > > # tc/tc class show dev tap0 > > > > > > class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > > class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > > class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > > class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > > > > So I'd like to ask if it might be useful for the TC users (may be > > > better format ?) to have this ? > > > > Good idea! It already looks good, but what about: > > > > |-- 1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | |-- 1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | |-- 1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | '-- 1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > |-- 1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > ... > > > > just another idea.. > > > > Thanks. > > Marcelo > > There are several places that also print tree format, hopefully there would > be reusable code (lspci, tree, ps). > OK, currently I have the following output: +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b How about this ? Regards, Vadim Kochan ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-17 23:56 ` Vadim Kochan @ 2014-12-18 1:56 ` Marcelo Ricardo Leitner 2014-12-18 3:12 ` Vadim Kochan 0 siblings, 1 reply; 16+ messages in thread From: Marcelo Ricardo Leitner @ 2014-12-18 1:56 UTC (permalink / raw) To: Vadim Kochan, Stephen Hemminger; +Cc: netdev On 17-12-2014 21:56, Vadim Kochan wrote: > On Wed, Dec 17, 2014 at 11:55:35AM -0800, Stephen Hemminger wrote: >> On Tue, 16 Dec 2014 16:12:41 -0200 >> Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote: >> >>> On 15-12-2014 20:48, vadim4j@gmail.com wrote: >>>> Hi All, >>>> >>>> I am playing with showing classes in more hierarchically format and I >>>> have some code and example of output from my TC looks like: >>>> >>>> # tc/tc -t class show dev tap0 >>>> >>>> \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> >>>> >>>> which in standart output mode it looks like: >>>> >>>> # tc/tc class show dev tap0 >>>> >>>> class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>>> class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>>> class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>> class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>> >>>> So I'd like to ask if it might be useful for the TC users (may be >>>> better format ?) to have this ? >>> >>> Good idea! It already looks good, but what about: >>> >>> |-- 1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | |-- 1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | |-- 1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | '-- 1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> |-- 1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> ... >>> >>> just another idea.. >>> >>> Thanks. >>> Marcelo >> >> There are several places that also print tree format, hopefully there would >> be reusable code (lspci, tree, ps). >> > > OK, currently I have the following output: > > +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | > +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > How about this ? Looks very good to me, thanks! > Regards, > Vadim Kochan > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 1:56 ` Marcelo Ricardo Leitner @ 2014-12-18 3:12 ` Vadim Kochan 2014-12-18 12:26 ` Marcelo Ricardo Leitner 0 siblings, 1 reply; 16+ messages in thread From: Vadim Kochan @ 2014-12-18 3:12 UTC (permalink / raw) To: Marcelo Ricardo Leitner; +Cc: Vadim Kochan, Stephen Hemminger, netdev On Wed, Dec 17, 2014 at 11:56:04PM -0200, Marcelo Ricardo Leitner wrote: > On 17-12-2014 21:56, Vadim Kochan wrote: > >On Wed, Dec 17, 2014 at 11:55:35AM -0800, Stephen Hemminger wrote: > >>On Tue, 16 Dec 2014 16:12:41 -0200 > >>Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote: > >> > >>>On 15-12-2014 20:48, vadim4j@gmail.com wrote: > >>>>Hi All, > >>>> > >>>>I am playing with showing classes in more hierarchically format and I > >>>>have some code and example of output from my TC looks like: > >>>> > >>>># tc/tc -t class show dev tap0 > >>>> > >>>> \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> > >>>> > >>>>which in standart output mode it looks like: > >>>> > >>>># tc/tc class show dev tap0 > >>>> > >>>>class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > >>>>class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > >>>>class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>>>class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>>> > >>>>So I'd like to ask if it might be useful for the TC users (may be > >>>>better format ?) to have this ? > >>> > >>>Good idea! It already looks good, but what about: > >>> > >>> |-- 1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>> | |-- 1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>> | |-- 1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>> | '-- 1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>> |-- 1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>> ... > >>> > >>>just another idea.. > >>> > >>>Thanks. > >>> Marcelo > >> > >>There are several places that also print tree format, hopefully there would > >>be reusable code (lspci, tree, ps). > >> > > > >OK, currently I have the following output: > > > >+---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > >| +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > >| +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > >| +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >| > >+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | | > > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | > > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > > >How about this ? > > Looks very good to me, thanks! > > >Regards, > >Vadim Kochan > > > There is an exampe output of tree with stats: +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | | | * Send 100 pkts ... | | | * Rate 10mbit ... | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | | * Send 100 pkts ... | | | * Rate 10mbit ... | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | * Send 100 pkts ... | * Rate 10mbit ... +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | | * Send 100 pkts ... | | | * Rate 10mbit ... | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | | * Send 100 pkts ... | | | | * Rate 10mbit ... | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | * Send 100 pkts ... | | | * Rate 10mbit ... | | | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | * Send 100 pkts ... | * Rate 10mbit ... Yeah, this is bigger one ... Regards, ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 3:12 ` Vadim Kochan @ 2014-12-18 12:26 ` Marcelo Ricardo Leitner 2014-12-18 12:23 ` Vadim Kochan 0 siblings, 1 reply; 16+ messages in thread From: Marcelo Ricardo Leitner @ 2014-12-18 12:26 UTC (permalink / raw) To: Vadim Kochan; +Cc: Stephen Hemminger, netdev On 18-12-2014 01:12, Vadim Kochan wrote: > On Wed, Dec 17, 2014 at 11:56:04PM -0200, Marcelo Ricardo Leitner wrote: >> On 17-12-2014 21:56, Vadim Kochan wrote: >>> On Wed, Dec 17, 2014 at 11:55:35AM -0800, Stephen Hemminger wrote: >>>> On Tue, 16 Dec 2014 16:12:41 -0200 >>>> Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote: >>>> >>>>> On 15-12-2014 20:48, vadim4j@gmail.com wrote: >>>>>> Hi All, >>>>>> >>>>>> I am playing with showing classes in more hierarchically format and I >>>>>> have some code and example of output from my TC looks like: >>>>>> >>>>>> # tc/tc -t class show dev tap0 >>>>>> >>>>>> \---1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:10 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:11 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:111 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:20 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> \---1:30 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> >>>>>> >>>>>> which in standart output mode it looks like: >>>>>> >>>>>> # tc/tc class show dev tap0 >>>>>> >>>>>> class htb 1:11 parent 1:10 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:111 parent 1:11 prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:10 parent 1:1 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>>>>> class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>>>>> class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>>> >>>>>> So I'd like to ask if it might be useful for the TC users (may be >>>>>> better format ?) to have this ? >>>>> >>>>> Good idea! It already looks good, but what about: >>>>> >>>>> |-- 1:2 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>> | |-- 1:40 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>> | |-- 1:50 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>> | '-- 1:60 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>> |-- 1:1 (htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>>>> ... >>>>> >>>>> just another idea.. >>>>> >>>>> Thanks. >>>>> Marcelo >>>> >>>> There are several places that also print tree format, hopefully there would >>>> be reusable code (lspci, tree, ps). >>>> >>> >>> OK, currently I have the following output: >>> >>> +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>> | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | >>> +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>> | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | >>> | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | >>> +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> >>> How about this ? >> >> Looks very good to me, thanks! >> >>> Regards, >>> Vadim Kochan >>> >> > > There is an exampe output of tree with stats: > > +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | > +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | | | * Send 100 pkts ... > | | | | * Rate 10mbit ... ^ these are confusing IMHO, rest looks good to me Marcelo > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | | > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > > > Yeah, this is bigger one ... > > Regards, > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 12:26 ` Marcelo Ricardo Leitner @ 2014-12-18 12:23 ` Vadim Kochan 2014-12-18 12:46 ` Marcelo Ricardo Leitner 0 siblings, 1 reply; 16+ messages in thread From: Vadim Kochan @ 2014-12-18 12:23 UTC (permalink / raw) To: Marcelo Ricardo Leitner; +Cc: Vadim Kochan, Stephen Hemminger, netdev On Thu, Dec 18, 2014 at 10:26:37AM -0200, Marcelo Ricardo Leitner wrote: > >+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > | * Send 100 pkts ... > > | * Rate 10mbit ... > > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > | | * Send 100 pkts ... > > | | * Rate 10mbit ... > > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > | | | * Send 100 pkts ... > > | | | * Rate 10mbit ... > > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | | | | * Send 100 pkts ... > > | | | | * Rate 10mbit ... > ^ these are confusing IMHO, rest looks good to me > > Marcelo > Yes, just fixed it to : +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | * Send 100 pkts ... | * Rate 10mbit ... | +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | * Send 100 pkts ... | * Rate 10mbit ... +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | | * Send 100 pkts ... | | * Rate 10mbit ... | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | | * Send 100 pkts ... | | | * Rate 10mbit ... | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | * Send 100 pkts ... | | | * Rate 10mbit ... | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | * Send 100 pkts ... | | * Rate 10mbit ... | | | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | * Send 100 pkts ... | * Rate 10mbit ... | +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | * Send 100 pkts ... | * Rate 10mbit ... +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b * Send 100 pkts ... * Rate 10mbit ... I am not sure about the better format to print stats - use '*' or '>' as prefix, '*' - seems better ? Regards, ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 12:23 ` Vadim Kochan @ 2014-12-18 12:46 ` Marcelo Ricardo Leitner 2014-12-18 13:16 ` Vadim Kochan 0 siblings, 1 reply; 16+ messages in thread From: Marcelo Ricardo Leitner @ 2014-12-18 12:46 UTC (permalink / raw) To: Vadim Kochan; +Cc: Stephen Hemminger, netdev On 18-12-2014 10:23, Vadim Kochan wrote: > On Thu, Dec 18, 2014 at 10:26:37AM -0200, Marcelo Ricardo Leitner wrote: >>> +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | * Send 100 pkts ... >>> | * Rate 10mbit ... >>> +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b >>> | | * Send 100 pkts ... >>> | | * Rate 10mbit ... >>> | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | | * Send 100 pkts ... >>> | | | * Rate 10mbit ... >>> | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b >>> | | | | * Send 100 pkts ... >>> | | | | * Rate 10mbit ... >> ^ these are confusing IMHO, rest looks good to me >> >> Marcelo >> > > > Yes, just fixed it to : Cool > +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > | > +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | | * Send 100 pkts ... > | | | * Rate 10mbit ... > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | | * Send 100 pkts ... > | | * Rate 10mbit ... > | | > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > | > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | * Send 100 pkts ... > | * Rate 10mbit ... > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > * Send 100 pkts ... > * Rate 10mbit ... > > I am not sure about the better format to print stats - use '*' or '>' as > prefix, '*' - seems better ? TBH I don't think we need one in there. It's already linked to the items due to the tree on them. If you just align them to start right where the the first word after the ')' begins, it would be good. Like: | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | | Send 100 pkts ... | | | Rate 10mbit ... | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | Send 100 pkts ... | | | Rate 10mbit ... | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b But I don't know how large this will get.. Yet I don't mind having one marker in there. Let's see what others think about it. Regards, Marcelo ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 12:46 ` Marcelo Ricardo Leitner @ 2014-12-18 13:16 ` Vadim Kochan 2014-12-18 13:47 ` Daniel Borkmann 0 siblings, 1 reply; 16+ messages in thread From: Vadim Kochan @ 2014-12-18 13:16 UTC (permalink / raw) To: Marcelo Ricardo Leitner; +Cc: Vadim Kochan, Stephen Hemminger, netdev On Thu, Dec 18, 2014 at 10:46:06AM -0200, Marcelo Ricardo Leitner wrote: > On 18-12-2014 10:23, Vadim Kochan wrote: > >On Thu, Dec 18, 2014 at 10:26:37AM -0200, Marcelo Ricardo Leitner wrote: > >>>+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>> | * Send 100 pkts ... > >>> | * Rate 10mbit ... > >>> +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > >>> | | * Send 100 pkts ... > >>> | | * Rate 10mbit ... > >>> | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > >>> | | | * Send 100 pkts ... > >>> | | | * Rate 10mbit ... > >>> | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >>> | | | | * Send 100 pkts ... > >>> | | | | * Rate 10mbit ... > >> ^ these are confusing IMHO, rest looks good to me > >> > >> Marcelo > >> > > > > > >Yes, just fixed it to : > > Cool > > >+---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > >| | * Send 100 pkts ... > >| | * Rate 10mbit ... > >| +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > >| | * Send 100 pkts ... > >| | * Rate 10mbit ... > >| +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > >| | * Send 100 pkts ... > >| | * Rate 10mbit ... > >| +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > >| * Send 100 pkts ... > >| * Rate 10mbit ... > >| > >+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b > > | * Send 100 pkts ... > > | * Rate 10mbit ... > > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b > > | | * Send 100 pkts ... > > | | * Rate 10mbit ... > > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > | | | * Send 100 pkts ... > > | | | * Rate 10mbit ... > > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | | | * Send 100 pkts ... > > | | | * Rate 10mbit ... > > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | | * Send 100 pkts ... > > | | * Rate 10mbit ... > > | | > > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > | * Send 100 pkts ... > > | * Rate 10mbit ... > > | > > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > > | * Send 100 pkts ... > > | * Rate 10mbit ... > > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b > > * Send 100 pkts ... > > * Rate 10mbit ... > > > >I am not sure about the better format to print stats - use '*' or '>' as > >prefix, '*' - seems better ? > > TBH I don't think we need one in there. It's already linked to the items due > to the tree on them. If you just align them to start right where the the > first word after the ')' begins, it would be good. Like: > > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b > | | | Send 100 pkts ... > | | | Rate 10mbit ... > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst > 1599b > | | | Send 100 pkts ... > | | | Rate 10mbit ... > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst > 1599b > > But I don't know how large this will get.. > > Yet I don't mind having one marker in there. Let's see what others think > about it. > > Regards, > Marcelo > I corrected regarding to your comments: +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | | Send 100 pkts ... | | Rate 10mbit ... | | | +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | | Send 100 pkts ... | | Rate 10mbit ... | | | +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | Send 100 pkts ... | | Rate 10mbit ... | | | +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | Send 100 pkts ... | Rate 10mbit ... | +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b | Send 100 pkts ... | Rate 10mbit ... | +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b | | Send 100 pkts ... | | Rate 10mbit ... | | | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | | | Send 100 pkts ... | | | Rate 10mbit ... | | | | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | | Send 100 pkts ... | | | Rate 10mbit ... | | | | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | | Send 100 pkts ... | | Rate 10mbit ... | | | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b | Send 100 pkts ... | Rate 10mbit ... | +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b | Send 100 pkts ... | Rate 10mbit ... | +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b Send 100 pkts ... Rate 10mbit ... The problem that this is huge now but looks better visually, I am thinking also about to possibiliy to show only some part of tree by specified parent id ... But how much classes can be used usually for traffic control per device ? Regards, Vadim Kochan ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 13:16 ` Vadim Kochan @ 2014-12-18 13:47 ` Daniel Borkmann 2014-12-18 13:46 ` Vadim Kochan 0 siblings, 1 reply; 16+ messages in thread From: Daniel Borkmann @ 2014-12-18 13:47 UTC (permalink / raw) To: Vadim Kochan; +Cc: Marcelo Ricardo Leitner, Stephen Hemminger, netdev, jhs On 12/18/2014 02:16 PM, Vadim Kochan wrote: ... > The problem that this is huge now but looks better visually, I am > thinking also about to possibiliy to show only some part of tree by specified parent id ... I definitely like this work! Just thinking out loud, what about an output option for tc which is plain DOT [1], thus it can be handed over for rendering in tools like graphviz? It won't require any dependencies either as it's just plaintext. [1] https://en.wikipedia.org/wiki/DOT_%28graph_description_language%29 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 13:47 ` Daniel Borkmann @ 2014-12-18 13:46 ` Vadim Kochan 2014-12-18 13:58 ` Thomas Graf 0 siblings, 1 reply; 16+ messages in thread From: Vadim Kochan @ 2014-12-18 13:46 UTC (permalink / raw) To: Daniel Borkmann Cc: Vadim Kochan, Marcelo Ricardo Leitner, Stephen Hemminger, netdev, jhs On Thu, Dec 18, 2014 at 02:47:38PM +0100, Daniel Borkmann wrote: > On 12/18/2014 02:16 PM, Vadim Kochan wrote: > ... > >The problem that this is huge now but looks better visually, I am > >thinking also about to possibiliy to show only some part of tree by specified parent id ... > > I definitely like this work! > > Just thinking out loud, what about an output option for tc which is plain > DOT [1], thus it can be handed over for rendering in tools like graphviz? > > It won't require any dependencies either as it's just plaintext. > > [1] https://en.wikipedia.org/wiki/DOT_%28graph_description_language%29 Yeah, good idea :-) ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 13:46 ` Vadim Kochan @ 2014-12-18 13:58 ` Thomas Graf 2014-12-24 13:59 ` Vadim Kochan 0 siblings, 1 reply; 16+ messages in thread From: Thomas Graf @ 2014-12-18 13:58 UTC (permalink / raw) To: Vadim Kochan Cc: Daniel Borkmann, Marcelo Ricardo Leitner, Stephen Hemminger, netdev, jhs On 12/18/14 at 03:46pm, Vadim Kochan wrote: > On Thu, Dec 18, 2014 at 02:47:38PM +0100, Daniel Borkmann wrote: > > On 12/18/2014 02:16 PM, Vadim Kochan wrote: > > ... > > >The problem that this is huge now but looks better visually, I am > > >thinking also about to possibiliy to show only some part of tree by specified parent id ... > > > > I definitely like this work! > > > > Just thinking out loud, what about an output option for tc which is plain > > DOT [1], thus it can be handed over for rendering in tools like graphviz? > > > > It won't require any dependencies either as it's just plaintext. > > > > [1] https://en.wikipedia.org/wiki/DOT_%28graph_description_language%29 > > Yeah, good idea :-) tcng had something like that ;-) ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-18 13:58 ` Thomas Graf @ 2014-12-24 13:59 ` Vadim Kochan 2014-12-24 15:07 ` Jamal Hadi Salim 0 siblings, 1 reply; 16+ messages in thread From: Vadim Kochan @ 2014-12-24 13:59 UTC (permalink / raw) To: Thomas Graf Cc: Daniel Borkmann, Marcelo Ricardo Leitner, Stephen Hemminger, netdev@vger.kernel.org, Jamal Hadi Salim On Thu, Dec 18, 2014 at 3:58 PM, Thomas Graf <tgraf@suug.ch> wrote: > On 12/18/14 at 03:46pm, Vadim Kochan wrote: >> On Thu, Dec 18, 2014 at 02:47:38PM +0100, Daniel Borkmann wrote: >> > On 12/18/2014 02:16 PM, Vadim Kochan wrote: >> > ... >> > >The problem that this is huge now but looks better visually, I am >> > >thinking also about to possibiliy to show only some part of tree by specified parent id ... >> > >> > I definitely like this work! >> > >> > Just thinking out loud, what about an output option for tc which is plain >> > DOT [1], thus it can be handed over for rendering in tools like graphviz? >> > >> > It won't require any dependencies either as it's just plaintext. >> > >> > [1] https://en.wikipedia.org/wiki/DOT_%28graph_description_language%29 >> >> Yeah, good idea :-) > > tcng had something like that ;-) I did not use tcng, but I think that it would be good to adopt some useful features to the tc. Regards, ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [iproute2] tc: Show classes more hierarchically] 2014-12-24 13:59 ` Vadim Kochan @ 2014-12-24 15:07 ` Jamal Hadi Salim 0 siblings, 0 replies; 16+ messages in thread From: Jamal Hadi Salim @ 2014-12-24 15:07 UTC (permalink / raw) To: Vadim Kochan, Thomas Graf Cc: Daniel Borkmann, Marcelo Ricardo Leitner, Stephen Hemminger, netdev@vger.kernel.org, Werner Almesberger, Cong Wang On 12/24/14 08:59, Vadim Kochan wrote: > On Thu, Dec 18, 2014 at 3:58 PM, Thomas Graf <tgraf@suug.ch> wrote: >> On 12/18/14 at 03:46pm, Vadim Kochan wrote: >>> On Thu, Dec 18, 2014 at 02:47:38PM +0100, Daniel Borkmann wrote: >>>> On 12/18/2014 02:16 PM, Vadim Kochan wrote: >>>> ... >>>>> The problem that this is huge now but looks better visually, I am >>>>> thinking also about to possibiliy to show only some part of tree by specified parent id ... >>>> >>>> I definitely like this work! >>>> >>>> Just thinking out loud, what about an output option for tc which is plain >>>> DOT [1], thus it can be handed over for rendering in tools like graphviz? >>>> >>>> It won't require any dependencies either as it's just plaintext. >>>> >>>> [1] https://en.wikipedia.org/wiki/DOT_%28graph_description_language%29 >>> >>> Yeah, good idea :-) >> >> tcng had something like that ;-) > > I did not use tcng, but I think that it would be good to adopt some > useful features to the tc. > Werner unfortunately wont be able to make netdev01 ;-> but we could have this discussion there. For the record I am enjoying seeing these patches as well;-> cheers, jamal ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2014-12-24 15:07 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-15 22:48 [iproute2] tc: Show classes more hierarchically] vadim4j 2014-12-16 13:49 ` Eric Dumazet 2014-12-16 18:12 ` Marcelo Ricardo Leitner 2014-12-17 19:55 ` Stephen Hemminger 2014-12-17 23:56 ` Vadim Kochan 2014-12-18 1:56 ` Marcelo Ricardo Leitner 2014-12-18 3:12 ` Vadim Kochan 2014-12-18 12:26 ` Marcelo Ricardo Leitner 2014-12-18 12:23 ` Vadim Kochan 2014-12-18 12:46 ` Marcelo Ricardo Leitner 2014-12-18 13:16 ` Vadim Kochan 2014-12-18 13:47 ` Daniel Borkmann 2014-12-18 13:46 ` Vadim Kochan 2014-12-18 13:58 ` Thomas Graf 2014-12-24 13:59 ` Vadim Kochan 2014-12-24 15:07 ` Jamal Hadi Salim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).