From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lino Sanfilippo Subject: Re: [PATCH net-next v3] Add support of Cavium Liquidio ethernet adapters Date: Fri, 19 Dec 2014 23:04:13 +0100 Message-ID: <5494A0DD.1010304@gmx.de> References: <1418959519-31681-1-git-send-email-rvatsavayi@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , Stephen Hemminger To: Raghu Vatsavayi , davem@davemloft.net Return-path: Received: from mout.gmx.net ([212.227.17.22]:63966 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbaLSWES (ORCPT ); Fri, 19 Dec 2014 17:04:18 -0500 In-Reply-To: <1418959519-31681-1-git-send-email-rvatsavayi@caviumnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On 19.12.2014 04:25, Raghu Vatsavayi wrote: > +static void cn6xxx_disable_interrupt(void *chip) > +{ > + struct octeon_cn6xxx *cn6xxx = (struct octeon_cn6xxx *)chip; > + > + /* Disable Interrupts */ > + writeq(0, cn6xxx->intr_enb_reg64); > +} > + This could also be a good candidate for forced write posting. The code assumes that interrupts are actually deactivated after that. Regards, Lino