From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jia-Ju Bai <baijiaju1990@163.com>,
todd.fujinaka@intel.com, netdev@vger.kernel.org
Cc: linux.nics@intel.com, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH] e1000 in linux-3.18.0: a potential bug
Date: Sat, 20 Dec 2014 16:27:50 +0300 [thread overview]
Message-ID: <54957956.30803@cogentembedded.com> (raw)
In-Reply-To: <000d01d01c29$a9edb870$fdc92950$@163.com>
Hello.
On 12/20/2014 10:50 AM, Jia-Ju Bai wrote:
> I have actually tested e1000 driver on the real hardware(Intel 82540EM PCI
> Gigabit Ethernet Controller), and find a potential bug:
> The target file is drivers/net/ethernet/intel/e1000/e1000_main.c, which is
> used to build e1000.ko.
> (1) In the normal process, netif_napi_add is called in e1000_probe, but
> netif_napi_del is not called in e1000_remove. However, many other ethernet
> card drivers call them in pairs, even in the error handling paths, such as
> r8169 and igb.
> Meanwhile, I also write the patch to fix the bug. I have run the patch on
> the hardware, it can work normally and fix the above bug.
You didn't sign off on your patch, so it can't be applied.
WBR, Sergei
next prev parent reply other threads:[~2014-12-20 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 7:50 [PATCH] e1000 in linux-3.18.0: a potential bug Jia-Ju Bai
2014-12-20 10:34 ` [linux-nics] " Jeff Kirsher
[not found] ` <79ea17da.119c.14a67bcadd1.Coremail.baijiaju1990@163.com>
2014-12-20 12:49 ` Jeff Kirsher
2014-12-20 13:27 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-20 13:57 Jia-Ju Bai
2014-12-20 14:15 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54957956.30803@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=baijiaju1990@163.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux.nics@intel.com \
--cc=netdev@vger.kernel.org \
--cc=todd.fujinaka@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).