From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jia-Ju Bai <baijiaju1990@163.com>,
netdev@vger.kernel.org, jgarzik@pobox.com, shangh@realtek.com.tw
Subject: Re: [PATCH] 8139too in linux-3.18.0: some potential bugs
Date: Sat, 20 Dec 2014 16:48:08 +0300 [thread overview]
Message-ID: <54957E18.8000803@cogentembedded.com> (raw)
In-Reply-To: <001601d01c57$be1e65a0$3a5b30e0$@163.com>
On 12/20/2014 4:20 PM, Jia-Ju Bai wrote:
> I have actually tested 8139too driver on the real hardware(Realtek RTL8139D
> PCI Ethernet Controller), and find some potential bugs:
> The target file is drivers/net/ethernet/realtek/8139too.c, which is used to
> build 8139too.ko.
> (1) In the normal process of 8139too, netif_napi_add is called in
> rtl8139_init_one, but netif_napi_del is not called in rtl8139_remove_one.
> However, many other ethernet card drivers call them in pairs, even in the
> error handling paths, such as r8169 and igb.
> (2) In the normal process of 8139too, pci_enable_device and
> pci_disable_device are called in pairs in rtl8139_init_board(in
> rtl8139_init_one) and rtl8139_remove_one. However, when pci_enable_device
> has been called and pci_request_regions is failed in rtl8139_init_board,
> "err_out" segment in rtl8139_init_board is executed immediately to exit, but
> pci_disable_device is not called because "disable_dev_on_err = 0".
Again, please fix one issue per patch.
> Meanwhile, I also write the patch to fix the bugs. I have run the patch on
> the hardware, it can work normally and fix the above bugs.
Too bad you didn't provide a sign-off...
WBR, Sergei
next prev parent reply other threads:[~2014-12-20 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 13:20 [PATCH] 8139too in linux-3.18.0: some potential bugs Jia-Ju Bai
2014-12-20 13:48 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-20 13:53 Jia-Ju Bai
2014-12-20 14:15 Jia-Ju Bai
2014-12-20 14:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54957E18.8000803@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=baijiaju1990@163.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shangh@realtek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).