From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jia-Ju Bai <baijiaju1990@163.com>, todd.fujinaka@intel.com
Cc: netdev@vger.kernel.org, Linux-nics@isotope.jf.intel.com,
linux.nics@intel.com, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH] e100 in linux-3.18.0: some potential bugs
Date: Sat, 20 Dec 2014 18:07:13 +0300 [thread overview]
Message-ID: <549590A1.1050107@cogentembedded.com> (raw)
In-Reply-To: <000201d01c61$bdb956b0$392c0410$@163.com>
On 12/20/2014 5:32 PM, Jia-Ju Bai wrote:
> I am inexperienced in submitting patches, sorry.
I see. It looks like you're failing to understand my English, too. :-(
Please put such remarks under the --- line which should be placed after
sign-off area.
> I have revised my patch:
You still need to revise it some more.
> 1.Check whether pci_pool_create is failed in e100_probe to avoid null
> dereference in pci_pool_alloc(in e100_alloc_cbs).
Please fix this issue by one (first) patch.
> 2.Add netif_napi_del to match the call of netif_napi_add.
And fix this one by another (second) patch.
Also, you need to insert empty line before sign-off.
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
... and after sign-off too.
> diff --git a/drivers/net/ethernet/intel/e100.c
> b/drivers/net/ethernet/intel/e100.c
> index 781065e..a58ab2e 100644
[...]
And finally, please re-post the patches in a new thread, not in reply to
this (or other) thread.
WBR, Sergei
next prev parent reply other threads:[~2014-12-20 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 14:32 [PATCH] e100 in linux-3.18.0: some potential bugs Jia-Ju Bai
2014-12-20 15:07 ` Sergei Shtylyov [this message]
2014-12-20 19:30 ` David Miller
2014-12-21 0:52 ` [PATCH V2] e1000: Add netif_napi_del in the normal path and error path to match netif_napi_add Jia-Ju Bai
2014-12-21 13:57 ` Sergei Shtylyov
2014-12-21 1:19 ` [PATCH V2 1/2] e100 in linux-3.18.0: Fix null pointer deference in e100_probe Jia-Ju Bai
2014-12-21 14:02 ` Sergei Shtylyov
2014-12-21 1:51 ` [PATCH V2 2/2] e100 in linux-3.18.0: Add netif_napi_del in the normal path and error path to match netif_napi_add Jia-Ju Bai
-- strict thread matches above, loose matches on Subject: below --
2014-12-20 7:40 [PATCH]e100 in linux-3.18.0: some potential bugs Jia-Ju Bai
2014-12-20 13:32 ` Sergei Shtylyov
2014-12-20 13:33 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549590A1.1050107@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Linux-nics@isotope.jf.intel.com \
--cc=baijiaju1990@163.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux.nics@intel.com \
--cc=netdev@vger.kernel.org \
--cc=todd.fujinaka@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).