From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Nils Holland <nholland@tisys.org>,
Prashant Sreedharan <prashant@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
rajatxjain@gmail.com, Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH net]tg3: tg3_disable_ints using uninitialized mailbox value to disable interrupts
Date: Mon, 22 Dec 2014 12:06:25 -0200 [thread overview]
Message-ID: <54982561.2080200@gmail.com> (raw)
In-Reply-To: <20141220221606.GA2591@teela.fritz.box>
On 20-12-2014 20:16, Nils Holland wrote:
> On Sat, Dec 20, 2014 at 12:16:17PM -0800, Prashant Sreedharan wrote:
>>
>> This driver bug was exposed because of the commit a7877b17a667 (PCI: Check only
>> the Vendor ID to identify Configuration Request Retry). Also this issue is only
>> seen in older generation chipsets like 5722 because config space write to offset
>> 0 from driver is possible.
>>
>> Fixed by initializing the interrupt mailbox registers before calling tg3_halt.
>>
>> Please queue for -stable.
>
> I gave this patch a try and can confirm what was to be expected: It
> fixes the issue and the network interface is once again working
> properly on my system. Thus, I guess the issue is adequately solved.
>
> Thanks to everyone involved, especially to Marcelo for additional
> debugging and the guys at Broadcom for the quick fix!
>
> Greetings,
> Nils
Same here, it works again.
Thanks!
Marcelo
next prev parent reply other threads:[~2014-12-22 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 20:16 [PATCH net]tg3: tg3_disable_ints using uninitialized mailbox value to disable interrupts Prashant Sreedharan
2014-12-20 22:16 ` Nils Holland
2014-12-22 14:06 ` Marcelo Ricardo Leitner [this message]
2014-12-22 21:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54982561.2080200@gmail.com \
--to=marcelo.leitner@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=linux-pci@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nholland@tisys.org \
--cc=prashant@broadcom.com \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).