netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nagendra Tomar <tomer_iisc@yahoo.com>
To: Davide Libenzi <davidel@xmailserver.org>,
	Eric Dumazet <dada1@cosmosbay.com>
Cc: Nagendra Tomar <tomer_iisc@yahoo.com>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets
Date: Thu, 20 Sep 2007 15:24:53 -0700 (PDT)	[thread overview]
Message-ID: <549830.78824.qm@web53705.mail.re2.yahoo.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0709201048290.8897@alien.or.mcafeemobile.com>


--- Davide Libenzi <davidel@xmailserver.org> wrote:

> 
> Unfortunately f_op->poll() does not let the caller to specify the events 
> it's interested in, that would allow to split send/recevie wait queues and 
> better detect read/write cases.
> The detection of a waitqueue_active(->sk_wr_sleep) would work fine in 
> detecting is someone is actually waiting for a write, w/out the false 
> positives triggered by the read-waiters.
> That would be a very sane thing to do, but would require a big&dumb change 
> to all the ->poll around (that could be automated by a script - devices 
> not caring about the events hint can just continue to use the single queue 
> like they currently do), and a more critical and gradual change of all the 
> devices that wants to take advantage of it.
> That way, no more magic bits are needed, and a simple waitqueue_active() 
> would tell you if someone is waiting for write-space events.
> 

I like this.





      ___________________________________________________________ 
To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

  reply	other threads:[~2007-09-20 22:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 22:37 [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets Nagendra Tomar
2007-09-19 22:44 ` David Miller
2007-09-19 22:55   ` Nagendra Tomar
2007-09-19 23:10     ` David Miller
2007-09-19 23:32       ` Nagendra Tomar
2007-09-19 23:11   ` Davide Libenzi
2007-09-19 23:50     ` Nagendra Tomar
2007-09-20  5:43       ` Davide Libenzi
2007-09-20  6:11       ` Eric Dumazet
2007-09-20  8:02         ` Nagendra Tomar
2007-09-20 17:56         ` Davide Libenzi
2007-09-20 22:24           ` Nagendra Tomar [this message]
2007-09-20 17:42 ` Davide Libenzi
2007-09-20 22:09   ` Nagendra Tomar
2007-09-20 22:37     ` Davide Libenzi
2007-09-20 22:58       ` Nagendra Tomar
2007-09-21 17:45         ` Davide Libenzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549830.78824.qm@web53705.mail.re2.yahoo.com \
    --to=tomer_iisc@yahoo.com \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).