From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: netdev <netdev@vger.kernel.org>, Eric Dumazet <edumazet@google.com>
Subject: Regression with commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses")
Date: Mon, 22 Dec 2014 16:17:38 +0100 [thread overview]
Message-ID: <54983612.8000600@6wind.com> (raw)
One of our engineer (Huaibin Wang <huaibin.wang@6wind.com>) has reported and
analysed this bug:
This commit introduces a regression with IPv6 + IPsec transport + TCP.
In TCP (net/ipv6/tcp_ipv6.c), xfrm6_policy_check() is called and thus, after
some intermediate functions, _decode_session6() is also called.
This function uses IP6CB() (u8 nexthdr = nh[IP6CB(skb)->nhoff]), which is wrong
becauses it has been moved to the end of TCP_SKB_CB().
Not sure what is the best way to fix this, any suggestion?
Regards,
Nicolas
next reply other threads:[~2014-12-22 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 15:17 Nicolas Dichtel [this message]
2014-12-22 16:15 ` Regression with commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses") Eric Dumazet
2014-12-22 16:54 ` Nicolas Dichtel
2014-12-22 17:22 ` [PATCH net] tcp6: don't move IP6CB before xfrm6_policy_check() Nicolas Dichtel
2014-12-22 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54983612.8000600@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).