From: Alex Gartrell <agartrell@fb.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <jasonwang@redhat.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mst@redhat.com>, <herbert@gondor.apena.org.au>,
<kernel-team@fb.com>
Subject: Re: [RFC PATCH net-next] tun: support retrieving multiple packets in a single read with IFF_MULTI_READ
Date: Mon, 22 Dec 2014 12:18:39 -0800 [thread overview]
Message-ID: <54987C9F.5070103@fb.com> (raw)
In-Reply-To: <20141222120957.GA21319@gondor.apana.org.au>
Hey Herbert,
Thanks for getting back to me
On 12/22/14 4:09 AM, Herbert Xu wrote:
> As tun already has a socket interface can we do this through
> recvmmsg?
This just presents an easier interface (IMHO) for accomplishing that.
And I say easier because I was unable how to figure out the recvmmsg way
to do it.
While fully aware that this makes me look like an idiot, I have to admit
that I've tried and failed to figure out how to get a socket fd out of
the tun device.
The regular fd doesn't work (which is obvious when you look at the
implementation sock_from_file), there's a tun_get_socket function but
it's only referenced by a single file, and none of the ioctl's jump out
at me as doing anything to enable this behavior. Additionally,
tuntap.txt makes no mention of sockets specifically.
FWIW, I don't feel strongly that IFF_MULTI_READ is the right way to do
this either.
Thanks,
--
Alex Gartrell <agartrell@fb.com>
next prev parent reply other threads:[~2014-12-22 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 4:00 [RFC PATCH net-next] tun: support retrieving multiple packets in a single read with IFF_MULTI_READ Alex Gartrell
2014-12-09 22:19 ` Stephen Hemminger
2014-12-22 12:09 ` Herbert Xu
2014-12-22 20:18 ` Alex Gartrell [this message]
2014-12-22 20:51 ` Dave Taht
2014-12-22 22:34 ` Herbert Xu
2014-12-22 23:39 ` Alex Gartrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54987C9F.5070103@fb.com \
--to=agartrell@fb.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=herbert@gondor.apena.org.au \
--cc=jasonwang@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).