From: Alex Gartrell <agartrell@fb.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <jasonwang@redhat.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mst@redhat.com>, <herbert@gondor.apena.org.au>,
<kernel-team@fb.com>
Subject: Re: [RFC PATCH net-next] tun: support retrieving multiple packets in a single read with IFF_MULTI_READ
Date: Mon, 22 Dec 2014 15:39:05 -0800 [thread overview]
Message-ID: <5498AB99.6060900@fb.com> (raw)
In-Reply-To: <20141222223436.GA25970@gondor.apana.org.au>
Hey Herbert,
On 12/22/2014 02:34 PM, Herbert Xu wrote:
> On Mon, Dec 22, 2014 at 12:18:39PM -0800, Alex Gartrell wrote:
>>
>> While fully aware that this makes me look like an idiot, I have to
>> admit that I've tried and failed to figure out how to get a socket
>> fd out of the tun device.
>
> Well right now the socket is only used within the kernel by
> vhost so it's not exported to user-space. If we were to use
> recvmmsg obviously we'd create a new interface based on sockets
> for tun and expose the existing socket through that.
Ah, that explains it then. I was afraid I was just going insane :)
> The current file-based tun interface was never designed to be
> a high-performance interface. So let's take this opportunity
> and create a new interface (but still using the same underlying
> code since whatever you create should be easily applicable to
> the existing kernel user vhost).
Sounds good to me. I'll get a patch turned around soon.
Thanks,
--
Alex Gartrell <agartrell@fb.com>
prev parent reply other threads:[~2014-12-22 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 4:00 [RFC PATCH net-next] tun: support retrieving multiple packets in a single read with IFF_MULTI_READ Alex Gartrell
2014-12-09 22:19 ` Stephen Hemminger
2014-12-22 12:09 ` Herbert Xu
2014-12-22 20:18 ` Alex Gartrell
2014-12-22 20:51 ` Dave Taht
2014-12-22 22:34 ` Herbert Xu
2014-12-22 23:39 ` Alex Gartrell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498AB99.6060900@fb.com \
--to=agartrell@fb.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=herbert@gondor.apena.org.au \
--cc=jasonwang@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).