* [PATCH] bonding: change error message to debug message in __bond_release_one()
@ 2014-12-23 1:24 Wengang Wang
2014-12-23 1:48 ` Ding Tianhong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wengang Wang @ 2014-12-23 1:24 UTC (permalink / raw)
To: netdev, gospo, dingtianhong; +Cc: wen.gang.wang
In __bond_release_one(), when the interface is not a slave or not a slave of
"this" master, it log error message.
The message actually should be a debug message matching what bond_enslave()
does.
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 184c434..0dceba1 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev,
/* slave is not a slave or master is not master of this slave */
if (!(slave_dev->flags & IFF_SLAVE) ||
!netdev_has_upper_dev(slave_dev, bond_dev)) {
- netdev_err(bond_dev, "cannot release %s\n",
+ netdev_dbg(bond_dev, "cannot release %s\n",
slave_dev->name);
return -EINVAL;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bonding: change error message to debug message in __bond_release_one()
2014-12-23 1:24 [PATCH] bonding: change error message to debug message in __bond_release_one() Wengang Wang
@ 2014-12-23 1:48 ` Ding Tianhong
2014-12-23 16:02 ` Andy Gospodarek
2014-12-25 23:29 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Ding Tianhong @ 2014-12-23 1:48 UTC (permalink / raw)
To: Wengang Wang, netdev, gospo
On 2014/12/23 9:24, Wengang Wang wrote:
> In __bond_release_one(), when the interface is not a slave or not a slave of
> "this" master, it log error message.
>
> The message actually should be a debug message matching what bond_enslave()
> does.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 184c434..0dceba1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev,
> /* slave is not a slave or master is not master of this slave */
> if (!(slave_dev->flags & IFF_SLAVE) ||
> !netdev_has_upper_dev(slave_dev, bond_dev)) {
> - netdev_err(bond_dev, "cannot release %s\n",
> + netdev_dbg(bond_dev, "cannot release %s\n",
> slave_dev->name);
> return -EINVAL;
> }
>
Acked-by: Ding Tianhong <dingtianhong@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bonding: change error message to debug message in __bond_release_one()
2014-12-23 1:24 [PATCH] bonding: change error message to debug message in __bond_release_one() Wengang Wang
2014-12-23 1:48 ` Ding Tianhong
@ 2014-12-23 16:02 ` Andy Gospodarek
2014-12-25 23:29 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andy Gospodarek @ 2014-12-23 16:02 UTC (permalink / raw)
To: Wengang Wang; +Cc: netdev, dingtianhong
On Tue, Dec 23, 2014 at 09:24:36AM +0800, Wengang Wang wrote:
> In __bond_release_one(), when the interface is not a slave or not a slave of
> "this" master, it log error message.
>
> The message actually should be a debug message matching what bond_enslave()
> does.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 184c434..0dceba1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev,
> /* slave is not a slave or master is not master of this slave */
> if (!(slave_dev->flags & IFF_SLAVE) ||
> !netdev_has_upper_dev(slave_dev, bond_dev)) {
> - netdev_err(bond_dev, "cannot release %s\n",
> + netdev_dbg(bond_dev, "cannot release %s\n",
> slave_dev->name);
> return -EINVAL;
> }
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bonding: change error message to debug message in __bond_release_one()
2014-12-23 1:24 [PATCH] bonding: change error message to debug message in __bond_release_one() Wengang Wang
2014-12-23 1:48 ` Ding Tianhong
2014-12-23 16:02 ` Andy Gospodarek
@ 2014-12-25 23:29 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-12-25 23:29 UTC (permalink / raw)
To: wen.gang.wang; +Cc: netdev, gospo, dingtianhong
From: Wengang Wang <wen.gang.wang@oracle.com>
Date: Tue, 23 Dec 2014 09:24:36 +0800
> In __bond_release_one(), when the interface is not a slave or not a slave of
> "this" master, it log error message.
>
> The message actually should be a debug message matching what bond_enslave()
> does.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-25 23:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-23 1:24 [PATCH] bonding: change error message to debug message in __bond_release_one() Wengang Wang
2014-12-23 1:48 ` Ding Tianhong
2014-12-23 16:02 ` Andy Gospodarek
2014-12-25 23:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).