From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: shh.xie@gmail.com, netdev@vger.kernel.org, davem@davemloft.net
Cc: Shaohui Xie <Shaohui.Xie@freescale.com>
Subject: Re: [PATCH 2/3] net/fsl: remove irq assignment from xgmac_mdio
Date: Tue, 23 Dec 2014 17:11:35 +0300 [thread overview]
Message-ID: <54997817.6010108@cogentembedded.com> (raw)
In-Reply-To: <1419328019-27254-1-git-send-email-shh.xie@gmail.com>
Hello.
On 12/23/2014 12:46 PM, shh.xie@gmail.com wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> Which is wrong and not used, so no extra space needed by
> mdio_alloc_size(), change the parameter accordingly.
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
> index 90adba1..72e0b85 100644
> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
> return ret;
> }
>
> - bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int));
> + bus = mdiobus_alloc_size(0);
It's now equivalent to a mere mdiobus_alloc().
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-12-23 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 9:46 [PATCH 2/3] net/fsl: remove irq assignment from xgmac_mdio shh.xie
2014-12-23 14:11 ` Sergei Shtylyov [this message]
2014-12-24 2:22 ` Shaohui Xie
2014-12-24 10:51 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54997817.6010108@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Shaohui.Xie@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shh.xie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).