From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Pravin B Shelar <pshelar@nicira.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net 5/6] openvswitch: Fix vport_send double free
Date: Wed, 24 Dec 2014 04:16:01 +0100 [thread overview]
Message-ID: <549A2FF1.2080300@gmx.de> (raw)
In-Reply-To: <1419380432-1665-1-git-send-email-pshelar@nicira.com>
Hi,
On 24.12.2014 01:20, Pravin B Shelar wrote:
l_hlen = ip_gre_calc_hlen(tun_key->tun_flags);
>
> @@ -183,8 +185,9 @@ static int gre_tnl_send(struct vport *vport, struct sk_buff *skb)
>
> /* Push Tunnel header. */
> skb = __build_header(skb, tunnel_hlen);
> - if (unlikely(!skb)) {
> - err = 0;
> + if (IS_ERR(skb)) {
> + err = PTR_ERR(rt);
Shouldn't be it
err = PTR_ERR(skb); ?
Regards,
Lino
prev parent reply other threads:[~2014-12-24 3:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 0:20 [PATCH net 5/6] openvswitch: Fix vport_send double free Pravin B Shelar
2014-12-24 3:16 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549A2FF1.2080300@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).