From: Alex Gartrell <agartrell@fb.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: <davem@davemloft.net>, <herbert@gondor.apana.org.au>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls
Date: Fri, 26 Dec 2014 14:59:33 -0500 [thread overview]
Message-ID: <549DBE25.3040302@fb.com> (raw)
In-Reply-To: <20141226195650.GF22149@ZenIV.linux.org.uk>
Hello Al,
On 12/26/14 2:56 PM, Al Viro wrote:
> On Thu, Dec 25, 2014 at 10:50:23PM -0800, Alex Gartrell wrote:
>> Currently the "is-socket" test for a file compares the ops table pointer,
>> which is static and local to the socket.c. Instead, this adds a flag for
>> private_data_is_socket. This is an exceptionally long commit message for a
>> two-line patch.
>
> NAK. Don't crap into struct file, please.
>
I don't disagree with your sentiment here. Is the additional f_op
approach less gross or do you have something else in mind?
Thanks,
--
Alex Gartrell <agartrell@fb.com>
next prev parent reply other threads:[~2014-12-26 20:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 6:50 [PATCH net-next 0/2] tun: support socket system calls Alex Gartrell
2014-12-26 6:50 ` [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls Alex Gartrell
2014-12-26 9:45 ` Jason Wang
2014-12-26 19:26 ` Alex Gartrell
2014-12-26 19:56 ` Al Viro
2014-12-26 19:59 ` Alex Gartrell [this message]
2014-12-26 6:50 ` [PATCH net-next 2/2] tun: enable socket system calls Alex Gartrell
2014-12-26 9:43 ` Jason Wang
2014-12-26 19:16 ` Alex Gartrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549DBE25.3040302@fb.com \
--to=agartrell@fb.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).