From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Enrico Mioso <mrkiko.rs@gmail.com>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/6] cdc_ncm: be more precise in comments for cdc_ncm_prepare_skb_ncm16
Date: Mon, 29 Dec 2014 16:29:40 +0300 [thread overview]
Message-ID: <54A15744.2050602@cogentembedded.com> (raw)
In-Reply-To: <1419847788-25610-3-git-send-email-mrkiko.rs@gmail.com>
Hello.
On 12/29/2014 1:09 PM, Enrico Mioso wrote:
> The function might return NULL: callers must be prepared to this possibility.
> Signed-Off-By: Enrico Mioso <mrkiko.rs@gmail.com>
> ---
> drivers/net/usb/cdc_ncm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
> index 48fee7a..bcd9437 100644
> --- a/drivers/net/usb/cdc_ncm.c
> +++ b/drivers/net/usb/cdc_ncm.c
> @@ -1015,7 +1015,7 @@ static struct usb_cdc_ncm_ndp16 *cdc_ncm_ndp16(struct cdc_ncm_ctx *ctx, struct s
> }
>
> /* Allocate new SKB for use with 16-bit NCM according to actual TX/RX
> - settings */
> + settings; returns NULL in case of errors */
BTW, the preferred style for the multi-line comments in the networking
code is:
/* bla
* bla
*/
WBR, Sergei
next prev parent reply other threads:[~2014-12-29 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 10:09 [RFC PATCH 0/6] cdc_ncm: some basic refactoring Enrico Mioso
2014-12-29 10:09 ` [RFC PATCH 1/6] cdc_ncm: factor out skb allocation and finalizzing Enrico Mioso
2014-12-29 10:09 ` [RFC PATCH 2/6] cdc_ncm: be more precise in comments for cdc_ncm_prepare_skb_ncm16 Enrico Mioso
2014-12-29 13:29 ` Sergei Shtylyov [this message]
2014-12-29 13:37 ` Enrico Mioso
2014-12-29 10:09 ` [RFC PATCH 3/6] cdc_ncm: add needed members to cdc_ncm_ctx for refactoring Enrico Mioso
2014-12-29 10:09 ` [RFC PATCH 4/6] cdc_ncm: update specs URL Enrico Mioso
2014-12-29 10:09 ` [RFC PATCH 5/6] cdc_ncm: fix typo Enrico Mioso
2014-12-29 10:09 ` [RFC PATCH 6/6] cdc_ncm: factor out NDP preparation and frame linking Enrico Mioso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A15744.2050602@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=mrkiko.rs@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).