From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sanjeev Sharma <sanjeev_sharma@mentor.com>, davem@davemloft.net
Cc: claudiu.manoil@freescale.com, peter.senna@gmail.com,
shemminger@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gianfar: correct the bad expression while writing bit-pattern
Date: Mon, 12 Jan 2015 17:12:11 +0300 [thread overview]
Message-ID: <54B3D63B.1010608@cogentembedded.com> (raw)
In-Reply-To: <1421048596-22639-1-git-send-email-sanjeev_sharma@mentor.com>
Hello.
On 1/12/2015 10:43 AM, Sanjeev Sharma wrote:
> This patch correct the bad expression while writing the
> bit-pattern from software's buffer to hardware registers.
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
> drivers/net/ethernet/freescale/gianfar_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> index 3e1a9c1..1ccca72 100644
> --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> @@ -1586,7 +1586,7 @@ static int gfar_write_filer_table(struct gfar_private *priv,
> return -EBUSY;
>
> /* Fill regular entries */
> - for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl);
> + for (; i < MAX_FILER_IDX - 1 && ( i < tab->fe[i].ctrl);
Inner parens not needed. And there shouldn't be space after (.
WBR, Sergei
next prev parent reply other threads:[~2015-01-12 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 7:43 [PATCH] gianfar: correct the bad expression while writing bit-pattern Sanjeev Sharma
2015-01-12 14:12 ` Sergei Shtylyov [this message]
2015-01-13 5:28 ` [PATCH v2] " Sanjeev Sharma
2015-01-13 6:01 ` Eric Dumazet
2015-01-13 6:15 ` Eric Dumazet
2015-01-12 14:22 ` [PATCH] " Claudiu Manoil
2015-02-03 7:32 ` [PATCH v3] " Sanjeev Sharma
2015-02-04 21:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3D63B.1010608@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=sanjeev_sharma@mentor.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).