From: Peter Hurley <peter@hurleysoftware.com>
To: Prashant Sreedharan <prashant@broadcom.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks
Date: Wed, 14 Jan 2015 10:57:50 -0500 [thread overview]
Message-ID: <54B691FE.50903@hurleysoftware.com> (raw)
In-Reply-To: <1421217039-11689-1-git-send-email-prashant@broadcom.com>
On 01/14/2015 01:30 AM, Prashant Sreedharan wrote:
> Prashant Sreedharan (3):
> tg3_timer() should grab tp->lock before checking for tp->irq_sync
> tg3_reset_task() needs to use rtnl_lock to synchronize
> Release tp->lock before invoking synchronize_irq()
Thanks!
For series:
Reported-by: Peter Hurley <peter@hurleysoftware.com>
Tested-by: Peter Hurley <peter@hurleysoftware.com>
But maybe one of these patches should reference that this fixes
BUG: sleeping function... so that others can quickly find this
fix (if they're bisecting or whatever). For the same reason, it
might be useful for this series to be just one patch.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-01-14 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:30 [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks Prashant Sreedharan
2015-01-14 15:57 ` Peter Hurley [this message]
2015-01-14 19:04 ` Prashant Sreedharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B691FE.50903@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).