From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use Date: Thu, 15 Jan 2015 13:19:16 +0530 Message-ID: <54B770FC.6060003@ti.com> References: <1421254729-10602-1-git-send-email-balbi@ti.com> <1421254729-10602-3-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: Tony Lindgren , Linux OMAP Mailing List , To: Felipe Balbi , Return-path: In-Reply-To: <1421254729-10602-3-git-send-email-balbi@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote: > CPSW never uses RX_THRESHOLD or MISC interrupts. In > fact, they are always kept masked in their appropriate > IRQ Enable register. > > Instead of allocating an IRQ that never fires, it's best > to remove that code altogether and let future patches > implement it if anybody needs those. > > Signed-off-by: Felipe Balbi Instead of introducing dummy ISR in previous patch and then removing in this patch, both can be squashed into a single patch. Regards Mugunthan V N