From: Or Gerlitz <ogerlitz@mellanox.com>
To: Marcelo Ricardo Leitner <mleitner@redhat.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: Compile-time warnings on mlx4/net-next
Date: Thu, 15 Jan 2015 15:20:47 +0200 [thread overview]
Message-ID: <54B7BEAF.6000406@mellanox.com> (raw)
In-Reply-To: <54B7BB17.8090308@redhat.com>
On 1/15/2015 3:05 PM, Marcelo Ricardo Leitner wrote:
> Hi Or,
>
> Building net-next.git from today, 4e7a84b1a5bc8094522fd11f628b00c4b4e78b4d,
> I'm seeing these warnings on mlx4:
>
> drivers/net/ethernet/mellanox/mlx4/fw.c: In function ‘mlx4_config_dev_retrieval’:
> drivers/net/ethernet/mellanox/mlx4/fw.c:2136:12: warning: ‘config_dev.rx_checksum_val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> csum_mask = (config_dev.rx_checksum_val >> CONFIG_DEV_RX_CSUM_MODE_PORT2_BIT_OFFSET) &
> ^
BTW in net-next.git this is line 2155 .. it's 2136 on net.git
> In file included from include/linux/swab.h:4:0,
> from include/uapi/linux/byteorder/little_endian.h:12,
> from include/linux/byteorder/little_endian.h:4,
> from ./arch/x86/include/uapi/asm/byteorder.h:4,
> from include/asm-generic/bitops/le.h:5,
> from ./arch/x86/include/asm/bitops.h:504,
> from include/linux/bitops.h:36,
> from include/linux/kernel.h:10,
> from include/linux/skbuff.h:17,
> from include/linux/if_ether.h:23,
> from include/linux/etherdevice.h:25,
> from drivers/net/ethernet/mellanox/mlx4/fw.c:35:
> include/uapi/linux/swab.h:106:23: warning: ‘config_dev.vxlan_udp_dport’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> (__builtin_constant_p((__u16)(x)) ? \
> ^
> drivers/net/ethernet/mellanox/mlx4/fw.c:2114:25: note: ‘config_dev.vxlan_udp_dport’ was declared here
> struct mlx4_config_dev config_dev;
> ^
>
> Do you see them too?
using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with
gcc 4.8.2 I don't see that, but I'll look there,
thanks for the report.
Or.
next prev parent reply other threads:[~2015-01-15 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 13:05 Compile-time warnings on mlx4/net-next Marcelo Ricardo Leitner
2015-01-15 13:20 ` Or Gerlitz [this message]
2015-01-15 13:38 ` Marcelo Ricardo Leitner
2015-01-16 11:45 ` Daniel Borkmann
2015-01-16 12:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7BEAF.6000406@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).