* Compile-time warnings on mlx4/net-next
@ 2015-01-15 13:05 Marcelo Ricardo Leitner
2015-01-15 13:20 ` Or Gerlitz
0 siblings, 1 reply; 5+ messages in thread
From: Marcelo Ricardo Leitner @ 2015-01-15 13:05 UTC (permalink / raw)
To: Or Gerlitz; +Cc: netdev
Hi Or,
Building net-next.git from today, 4e7a84b1a5bc8094522fd11f628b00c4b4e78b4d,
I'm seeing these warnings on mlx4:
drivers/net/ethernet/mellanox/mlx4/fw.c: In function ‘mlx4_config_dev_retrieval’:
drivers/net/ethernet/mellanox/mlx4/fw.c:2136:12: warning: ‘config_dev.rx_checksum_val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
csum_mask = (config_dev.rx_checksum_val >> CONFIG_DEV_RX_CSUM_MODE_PORT2_BIT_OFFSET) &
^
In file included from include/linux/swab.h:4:0,
from include/uapi/linux/byteorder/little_endian.h:12,
from include/linux/byteorder/little_endian.h:4,
from ./arch/x86/include/uapi/asm/byteorder.h:4,
from include/asm-generic/bitops/le.h:5,
from ./arch/x86/include/asm/bitops.h:504,
from include/linux/bitops.h:36,
from include/linux/kernel.h:10,
from include/linux/skbuff.h:17,
from include/linux/if_ether.h:23,
from include/linux/etherdevice.h:25,
from drivers/net/ethernet/mellanox/mlx4/fw.c:35:
include/uapi/linux/swab.h:106:23: warning: ‘config_dev.vxlan_udp_dport’ may be used uninitialized in this function [-Wmaybe-uninitialized]
(__builtin_constant_p((__u16)(x)) ? \
^
drivers/net/ethernet/mellanox/mlx4/fw.c:2114:25: note: ‘config_dev.vxlan_udp_dport’ was declared here
struct mlx4_config_dev config_dev;
^
Do you see them too?
Marcelo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile-time warnings on mlx4/net-next
2015-01-15 13:05 Compile-time warnings on mlx4/net-next Marcelo Ricardo Leitner
@ 2015-01-15 13:20 ` Or Gerlitz
2015-01-15 13:38 ` Marcelo Ricardo Leitner
0 siblings, 1 reply; 5+ messages in thread
From: Or Gerlitz @ 2015-01-15 13:20 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: netdev
On 1/15/2015 3:05 PM, Marcelo Ricardo Leitner wrote:
> Hi Or,
>
> Building net-next.git from today, 4e7a84b1a5bc8094522fd11f628b00c4b4e78b4d,
> I'm seeing these warnings on mlx4:
>
> drivers/net/ethernet/mellanox/mlx4/fw.c: In function ‘mlx4_config_dev_retrieval’:
> drivers/net/ethernet/mellanox/mlx4/fw.c:2136:12: warning: ‘config_dev.rx_checksum_val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> csum_mask = (config_dev.rx_checksum_val >> CONFIG_DEV_RX_CSUM_MODE_PORT2_BIT_OFFSET) &
> ^
BTW in net-next.git this is line 2155 .. it's 2136 on net.git
> In file included from include/linux/swab.h:4:0,
> from include/uapi/linux/byteorder/little_endian.h:12,
> from include/linux/byteorder/little_endian.h:4,
> from ./arch/x86/include/uapi/asm/byteorder.h:4,
> from include/asm-generic/bitops/le.h:5,
> from ./arch/x86/include/asm/bitops.h:504,
> from include/linux/bitops.h:36,
> from include/linux/kernel.h:10,
> from include/linux/skbuff.h:17,
> from include/linux/if_ether.h:23,
> from include/linux/etherdevice.h:25,
> from drivers/net/ethernet/mellanox/mlx4/fw.c:35:
> include/uapi/linux/swab.h:106:23: warning: ‘config_dev.vxlan_udp_dport’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> (__builtin_constant_p((__u16)(x)) ? \
> ^
> drivers/net/ethernet/mellanox/mlx4/fw.c:2114:25: note: ‘config_dev.vxlan_udp_dport’ was declared here
> struct mlx4_config_dev config_dev;
> ^
>
> Do you see them too?
using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with
gcc 4.8.2 I don't see that, but I'll look there,
thanks for the report.
Or.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile-time warnings on mlx4/net-next
2015-01-15 13:20 ` Or Gerlitz
@ 2015-01-15 13:38 ` Marcelo Ricardo Leitner
2015-01-16 11:45 ` Daniel Borkmann
0 siblings, 1 reply; 5+ messages in thread
From: Marcelo Ricardo Leitner @ 2015-01-15 13:38 UTC (permalink / raw)
To: Or Gerlitz; +Cc: netdev
On 15-01-2015 11:20, Or Gerlitz wrote:
> On 1/15/2015 3:05 PM, Marcelo Ricardo Leitner wrote:
>> Hi Or,
>>
>> Building net-next.git from today, 4e7a84b1a5bc8094522fd11f628b00c4b4e78b4d,
>> I'm seeing these warnings on mlx4:
>>
>> drivers/net/ethernet/mellanox/mlx4/fw.c: In function
>> ‘mlx4_config_dev_retrieval’:
>> drivers/net/ethernet/mellanox/mlx4/fw.c:2136:12: warning:
>> ‘config_dev.rx_checksum_val’ may be used uninitialized in this function
>> [-Wmaybe-uninitialized]
>> csum_mask = (config_dev.rx_checksum_val >>
>> CONFIG_DEV_RX_CSUM_MODE_PORT2_BIT_OFFSET) &
>> ^
> BTW in net-next.git this is line 2155 .. it's 2136 on net.git
sure?
https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next/+/4e7a84b1a5bc8094522fd11f628b00c4b4e78b4d/drivers/net/ethernet/mellanox/mlx4/fw.c
or
https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next/+/master/drivers/net/ethernet/mellanox/mlx4/fw.c
says line 2136 for net-next too
>> In file included from include/linux/swab.h:4:0,
>> from include/uapi/linux/byteorder/little_endian.h:12,
>> from include/linux/byteorder/little_endian.h:4,
>> from ./arch/x86/include/uapi/asm/byteorder.h:4,
>> from include/asm-generic/bitops/le.h:5,
>> from ./arch/x86/include/asm/bitops.h:504,
>> from include/linux/bitops.h:36,
>> from include/linux/kernel.h:10,
>> from include/linux/skbuff.h:17,
>> from include/linux/if_ether.h:23,
>> from include/linux/etherdevice.h:25,
>> from drivers/net/ethernet/mellanox/mlx4/fw.c:35:
>> include/uapi/linux/swab.h:106:23: warning: ‘config_dev.vxlan_udp_dport’ may
>> be used uninitialized in this function [-Wmaybe-uninitialized]
>> (__builtin_constant_p((__u16)(x)) ? \
>> ^
>> drivers/net/ethernet/mellanox/mlx4/fw.c:2114:25: note:
>> ‘config_dev.vxlan_udp_dport’ was declared here
>> struct mlx4_config_dev config_dev;
>> ^
>>
>> Do you see them too?
>
> using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with gcc
> 4.8.2 I don't see that, but I'll look there,
> thanks for the report.
Aye, thanks.
Marcelo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile-time warnings on mlx4/net-next
2015-01-15 13:38 ` Marcelo Ricardo Leitner
@ 2015-01-16 11:45 ` Daniel Borkmann
2015-01-16 12:54 ` Eric Dumazet
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Borkmann @ 2015-01-16 11:45 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: Or Gerlitz, netdev
On 01/15/2015 02:38 PM, Marcelo Ricardo Leitner wrote:
> On 15-01-2015 11:20, Or Gerlitz wrote:
...
>>> Do you see them too?
>>
>> using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with gcc
>> 4.8.2 I don't see that, but I'll look there,
>> thanks for the report.
I believe they are there for quite some time already. I'm using gcc 4.8.3
and just default build. I'm surprised Fengguang didn't complain yet (or
he did, but it got ignored somehow ;)). The following should be sufficient
to just shut gcc up:
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
index 982861d..b01154d 100644
--- a/drivers/net/ethernet/mellanox/mlx4/fw.c
+++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
@@ -2122,6 +2122,7 @@ int mlx4_config_dev_retrieval(struct mlx4_dev *dev,
if (!(dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_CONFIG_DEV))
return -ENOTSUPP;
+ memset(&config_dev, 0, sizeof(config_dev));
err = mlx4_CONFIG_DEV_get(dev, &config_dev);
if (err)
return err;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: Compile-time warnings on mlx4/net-next
2015-01-16 11:45 ` Daniel Borkmann
@ 2015-01-16 12:54 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2015-01-16 12:54 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: Marcelo Ricardo Leitner, Or Gerlitz, netdev
On Fri, 2015-01-16 at 12:45 +0100, Daniel Borkmann wrote:
> On 01/15/2015 02:38 PM, Marcelo Ricardo Leitner wrote:
> > On 15-01-2015 11:20, Or Gerlitz wrote:
> ...
> >>> Do you see them too?
> >>
> >> using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with gcc
> >> 4.8.2 I don't see that, but I'll look there,
> >> thanks for the report.
>
> I believe they are there for quite some time already. I'm using gcc 4.8.3
> and just default build. I'm surprised Fengguang didn't complain yet (or
> he did, but it got ignored somehow ;)). The following should be sufficient
> to just shut gcc up:
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> index 982861d..b01154d 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> @@ -2122,6 +2122,7 @@ int mlx4_config_dev_retrieval(struct mlx4_dev *dev,
> if (!(dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_CONFIG_DEV))
> return -ENOTSUPP;
>
> + memset(&config_dev, 0, sizeof(config_dev));
> err = mlx4_CONFIG_DEV_get(dev, &config_dev);
> if (err)
> return err;
Yeah, I reported the same issue some time back.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-16 12:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 13:05 Compile-time warnings on mlx4/net-next Marcelo Ricardo Leitner
2015-01-15 13:20 ` Or Gerlitz
2015-01-15 13:38 ` Marcelo Ricardo Leitner
2015-01-16 11:45 ` Daniel Borkmann
2015-01-16 12:54 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).