From: Xander Huff <xander.huff@ni.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, jaeden.amero@ni.com,
rich.tollerton@ni.com, ben.shelton@ni.com, brad.mouring@ni.com,
linux-kernel@vger.kernel.org, cyrille.pitchen@atmel.com
Subject: Re: [PATCH v2 2/2] fixup! net/macb: improved ethtool statistics support
Date: Thu, 15 Jan 2015 09:32:35 -0600 [thread overview]
Message-ID: <54B7DD93.8000104@ni.com> (raw)
In-Reply-To: <54B797E5.6070503@atmel.com>
On 1/15/2015 4:35 AM, Nicolas Ferre wrote:
>> #define GEM_OTX 0x0100 /* Octets transmitted */
> I see, it's modified hereafter! Why not integrate this part in previous
> patch?
>
>
I split these up the way I did by using the --fixup argument to allow the rebase
--autosquash to work. I could instead have a series of fixup commits to fix each
type of style issue and then also the functional issue if you'd prefer, but
--autosquash will no longer work.
next prev parent reply other threads:[~2015-01-15 15:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 22:15 [PATCH 1/2] net/macb: Adding comments to various #defs to make interpretation easier Xander Huff
2015-01-13 22:15 ` [PATCH 2/2] net/macb: improved ethtool statistics support Xander Huff
2015-01-14 5:26 ` David Miller
2015-01-14 15:53 ` Nicolas Ferre
2015-01-14 20:21 ` [PATCH 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier Xander Huff
2015-01-14 20:21 ` [PATCH 2/2] fixup! net/macb: improved ethtool statistics support Xander Huff
2015-01-14 21:09 ` [PATCH 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier David Miller
2015-01-14 21:18 ` Xander Huff
2015-01-14 21:52 ` David Miller
2015-01-14 22:20 ` [PATCH v2 " Xander Huff
2015-01-14 22:20 ` [PATCH v2 2/2] fixup! net/macb: improved ethtool statistics support Xander Huff
2015-01-15 10:35 ` Nicolas Ferre
2015-01-15 15:32 ` Xander Huff [this message]
2015-01-15 10:05 ` [PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier Nicolas Ferre
2015-01-15 11:46 ` David Laight
2015-01-15 21:45 ` [PATCH v3 1/3] net/macb: Fix comments to meet style guidelines Xander Huff
2015-01-15 21:45 ` [PATCH v3 2/3] net/macb: Add whitespace around arithmetic operators Xander Huff
2015-01-16 5:32 ` David Miller
2015-01-15 21:45 ` [PATCH v3 3/3] net/macb: Create gem_ethtool_ops for new statistics functions Xander Huff
2015-01-16 5:32 ` David Miller
2015-01-16 5:31 ` [PATCH v3 1/3] net/macb: Fix comments to meet style guidelines David Miller
2015-01-15 21:55 ` Xander Huff
2015-01-15 21:55 ` [PATCH v3 2/3] net/macb: Add whitespace around arithmetic operators Xander Huff
2015-01-15 21:55 ` [PATCH v3 3/3] net/macb: Create gem_ethtool_ops for new statistics functions Xander Huff
2015-01-14 21:04 ` [PATCH 2/2] net/macb: improved ethtool statistics support David Miller
2015-01-14 5:26 ` [PATCH 1/2] net/macb: Adding comments to various #defs to make interpretation easier David Miller
2015-01-14 15:11 ` Brad Mouring
2015-01-14 15:10 ` Nicolas Ferre
[not found] ` <OFE030E01C.93929A2C-ON86257DCD.00524615-86257DCD.0052461A@ni.com>
2015-01-14 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7DD93.8000104@ni.com \
--to=xander.huff@ni.com \
--cc=ben.shelton@ni.com \
--cc=brad.mouring@ni.com \
--cc=cyrille.pitchen@atmel.com \
--cc=davem@davemloft.net \
--cc=jaeden.amero@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rich.tollerton@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).