From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>,
ct178-internal@lists.codethink.co.uk,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@lists.codethink.co.uk,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>,
Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>
Subject: Re: [PATCH net 1/2] sh_eth: Fix promiscuous mode on chips without TSU
Date: Fri, 16 Jan 2015 22:36:42 +0300 [thread overview]
Message-ID: <54B9684A.8060302@cogentembedded.com> (raw)
In-Reply-To: <54B9663D.2040008@cogentembedded.com>
On 01/16/2015 10:27 PM, Sergei Shtylyov wrote:
>> Currently net_device_ops::set_rx_mode is only implemented for
>> chips with a TSU (multiple address table). However we do need
>> to turn the PRM (promiscuous) flag on and off for other chips.
[...]
>> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
[...]
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index 167737f..0c4d5b5 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
>> @@ -2440,7 +2440,7 @@ static void sh_eth_tsu_purge_mcast(struct net_device
>> *ndev)
>> void *reg_offset = sh_eth_tsu_get_offset(mdp, TSU_ADRH0);
>> int i;
>>
>> - if (unlikely(!mdp->cd->tsu))
>> + if (!mdp->cd->tsu)
> But we don't call this function on non-TSU SoCs, do we?
Sorry, we do.
> [...]
WBR, Sergei
next prev parent reply other threads:[~2015-01-16 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 17:49 [PATCH net 0/2] sh_eth fixes Ben Hutchings
2015-01-16 17:51 ` [PATCH net 1/2] sh_eth: Fix promiscuous mode on chips without TSU Ben Hutchings
2015-01-16 19:27 ` Sergei Shtylyov
2015-01-16 19:36 ` Sergei Shtylyov [this message]
2015-01-19 10:45 ` Ben Hutchings
2015-01-16 17:51 ` [PATCH net 2/2] sh_eth: Fix ethtool operation crash when net device is down Ben Hutchings
2015-01-16 18:45 ` Florian Fainelli
2015-01-19 10:41 ` Ben Hutchings
2015-01-19 17:28 ` Florian Fainelli
2015-01-19 20:38 ` [PATCH net 0/2] sh_eth fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B9684A.8060302@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=ct178-internal@lists.codethink.co.uk \
--cc=davem@davemloft.net \
--cc=hisashi.nakamura.ak@renesas.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).