From: David Ahern <dsahern@gmail.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH] net: rocker: Add basic netdev counters - v2
Date: Fri, 16 Jan 2015 16:48:59 -0700 [thread overview]
Message-ID: <54B9A36B.1050204@gmail.com> (raw)
In-Reply-To: <CAE4R7bA3QG4LDvVQywDsRuJzJYv4mBq3=OXi2L=qGDfa4a8ykw@mail.gmail.com>
On 1/16/15 4:41 PM, Scott Feldman wrote:
>
> Thanks David. I think this is good enough for first pass. Longer
> term, I'd like to see this replaced by stats read from device for each
> port.
Aren't there 2 sets of stats at play here?
1. packets punted to the control plane / CPU,
2. packets forwarded through the ports.
If you have the netdev counters resemble packets handled through the
port it could be confusing to someone looking at packets handled by the OS.
What about having detailed counters local to the driver (i.e., ethtool
-S) show the low level stats like packets handled through the port?
David
next prev parent reply other threads:[~2015-01-16 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 21:22 [PATCH] net: rocker: Add basic netdev counters - v2 David Ahern
2015-01-16 23:41 ` Scott Feldman
2015-01-16 23:48 ` David Ahern [this message]
2015-01-17 0:08 ` Scott Feldman
2015-01-18 6:56 ` David Miller
2015-01-17 8:29 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B9A36B.1050204@gmail.com \
--to=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).