From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH v2 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA Date: Mon, 19 Jan 2015 23:10:30 +0100 Message-ID: <54BD80D6.40402@redhat.com> References: <1421703363-3376-1-git-send-email-harouth@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Harout Hedeshian Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58858 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbbASWKe (ORCPT ); Mon, 19 Jan 2015 17:10:34 -0500 In-Reply-To: <1421703363-3376-1-git-send-email-harouth@codeaurora.org> Sender: netdev-owner@vger.kernel.org List-ID: On 01/19/2015 10:36 PM, Harout Hedeshian wrote: ... > diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h > index 0956373..45e4fcf 100644 > --- a/include/uapi/linux/sysctl.h > +++ b/include/uapi/linux/sysctl.h > @@ -570,6 +570,7 @@ enum { > NET_IPV6_PROXY_NDP=23, > NET_IPV6_ACCEPT_SOURCE_ROUTE=25, > NET_IPV6_ACCEPT_RA_FROM_LOCAL=26, > + NET_IPV6_ACCEPT_RA_MTU=27, > __NET_IPV6_MAX > }; > > diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c > index 7e7746a..16091e5 100644 > --- a/kernel/sysctl_binary.c > +++ b/kernel/sysctl_binary.c > @@ -523,6 +523,7 @@ static const struct bin_table bin_net_ipv6_conf_var_table[] = { > { CTL_INT, NET_IPV6_PROXY_NDP, "proxy_ndp" }, > { CTL_INT, NET_IPV6_ACCEPT_SOURCE_ROUTE, "accept_source_route" }, > { CTL_INT, NET_IPV6_ACCEPT_RA_FROM_LOCAL, "accept_ra_from_local" }, > + { CTL_INT, NET_IPV6_ACCEPT_RA_MTU, "accept_ra_mtu" }, > {} > }; Hm, afaik, the binary sysctl interface is deprecated and nothing should be adding entries there anymore. I believe you copied this over from commit d9333196572 ("ipv6: Allow accepting RA from local IP addresses.")? :/