netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Harout Hedeshian <harouth@codeaurora.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA
Date: Tue, 20 Jan 2015 00:01:04 +0100	[thread overview]
Message-ID: <54BD8CB0.8050800@redhat.com> (raw)
In-Reply-To: <1421703363-3376-1-git-send-email-harouth@codeaurora.org>

On 01/19/2015 10:36 PM, Harout Hedeshian wrote:
...
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index 85b0221..da50faa 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -1287,6 +1287,13 @@ accept_ra_rtr_pref - BOOLEAN
>   	Functional default: enabled if accept_ra is enabled.
>   			    disabled if accept_ra is disabled.
>
> +accept_ra_mtu - BOOLEAN
> +	Apply the MTU value specified in RA option 5 (RFC4861). If
> +	disabled, the MTU specified in the RA will be ignored.
> +
> +	Functional default: enabled if accept_ra is enabled.
> +                            disabled if accept_ra is disabled.

Nit: please indent correctly with tab here.

> +
...
> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
> index 73cb02d..437a6a4 100644
> --- a/include/uapi/linux/ipv6.h
> +++ b/include/uapi/linux/ipv6.h
> @@ -169,6 +169,7 @@ enum {
>   	DEVCONF_SUPPRESS_FRAG_NDISC,
>   	DEVCONF_ACCEPT_RA_FROM_LOCAL,
>   	DEVCONF_USE_OPTIMISTIC,
> +	DEVCONF_ACCEPT_RA_MTU,
>   	DEVCONF_MAX
>   };

You also need a corresponding ipv6_store_devconf() entry, otherwise
netlink dumps will always see this setting as disabled.

  parent reply	other threads:[~2015-01-19 23:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 21:36 [PATCH v2 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA Harout Hedeshian
2015-01-19 22:10 ` Daniel Borkmann
2015-01-19 22:42   ` Harout Hedeshian
2015-01-19 23:01     ` Daniel Borkmann
2015-01-20  0:29     ` David Miller
2015-01-19 23:01 ` Daniel Borkmann [this message]
2015-01-20 16:48   ` Harout Hedeshian
2015-01-20 16:56     ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BD8CB0.8050800@redhat.com \
    --to=dborkman@redhat.com \
    --cc=harouth@codeaurora.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).