From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mugunthan V N <mugunthanvnm@ti.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, stable@vger.kernel.org
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: discard dual emac default vlan configuration
Date: Tue, 20 Jan 2015 17:25:55 +0300 [thread overview]
Message-ID: <54BE6573.1040801@cogentembedded.com> (raw)
In-Reply-To: <1421756740-32180-1-git-send-email-mugunthanvnm@ti.com>
Hello.
On 1/20/2015 3:25 PM, Mugunthan V N wrote:
> In Dual EMAC, the default vlans are used to segregate rx packets between
VLANs. And RX.
> the ports, so adding the same default vlan to the switch will affect the
VLAN.
> normal packet transfers. So returning error on addition of dual emac
EMAC.
> default vlans.
VLANs.
> Even if emac 0 default port vlan is added to emac 1, it will lead to
EMAC. And VLAN
> break
Breaking.
> dual EMAC port seperations.
Separations.
> Fixes: d9ba8f9 (driver: net: ethernet: cpsw: dual emac interface implementation)
12 hex digits, please.
> Cc: <stable@vger.kernel.org> # v3.9+
> Reported-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> drivers/net/ethernet/ti/cpsw.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index e068d48..7c32815 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1683,6 +1683,19 @@ static int cpsw_ndo_vlan_rx_add_vid(struct net_device *ndev,
> if (vid == priv->data.default_vlan)
> return 0;
>
> + if (priv->data.dual_emac) {
> + /* In dual EMAC, reserved VLAN id should not be used of
s/of/for/, perhaps?
> + * creating vlan interfaces as this can break the dual
s/vlan/VLAN/. Be consistent, please.
> + * EMAC port seperation
Separation.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-01-20 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 12:25 [net PATCH 1/1] drivers: net: cpsw: discard dual emac default vlan configuration Mugunthan V N
2015-01-20 14:25 ` Sergei Shtylyov [this message]
2015-01-22 8:20 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BE6573.1040801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).