From: Rick Jones <rick.jones2@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, Dave Taht <dave.taht@gmail.com>
Cc: Eyal Perry <eyalpe@mellanox.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Eyal Perry <eyalpe@dev.mellanox.co.il>,
Or Gerlitz <gerlitz.or@gmail.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Amir Vadai <amirv@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Ido Shamay <idos@mellanox.com>, Amir Ancel <amira@mellanox.com>
Subject: Re: BW regression after "tcp: refine TSO autosizing"
Date: Tue, 20 Jan 2015 11:14:37 -0800 [thread overview]
Message-ID: <54BEA91D.1050001@hp.com> (raw)
In-Reply-To: <1421723651.17892.3.camel@edumazet-glaptop2.roam.corp.google.com>
>> Are you saying that at long last, delayed acks as we knew them are
>> dead, dead, dead?
>
> Sorry, I can not parse what you are saying.
>
> In case you missed it, it has nothing to do with delayed ACK but GRO on
> receiver.
Dave - assuming I've interpreted Eric's comments correctly, I believe
the answer to your question is No. Your desire for a world brimming
with ack-every-other purity has not been fulfilled :)
However, the engineers formerly at Mentat are probably pleased that a
functional near-equivalent to their ACK avoidance heuristic has ended-up
being implemented and tacitly accepted, albeit by the back door :)
>>> DUMP_TCP_INFO=1 ./netperf -H remote -T2,2 -t TCP_STREAM -l 20
>>> MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to remote () port 0 AF_INET : cpu bind
>>> rto=201000 ato=0 pmtu=1500 rcv_ssthresh=29200 rtt=67 rttvar=6 snd_ssthresh=263 cwnd=265 reordering=3 total_retrans=4569 ca_state=0
>>
>> The above statistics are not dumped by my netperf, and look extremely
>> desirable to capture in netperf-wrapper. This is a script parsing some
>> other kernel data at the conclusion of the run? or a better netperf?
>
> Thats a 3 lines patch in netperf actually.
More stuff to pull from a TCP_INFO call I presume? Feel free to drop me
a patch, though I'd probably want it to be in the guise of the omni
output selectors.
happy benchmarking,
rick
next prev parent reply other threads:[~2015-01-20 19:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 16:48 BW regression after "tcp: refine TSO autosizing" Eyal Perry
2015-01-13 18:57 ` Eric Dumazet
2015-01-13 20:21 ` Or Gerlitz
2015-01-13 21:41 ` Eyal Perry
2015-01-13 22:00 ` Eric Dumazet
2015-01-18 16:22 ` Eyal Perry
2015-01-18 17:48 ` Eric Dumazet
2015-01-18 21:40 ` Eyal Perry
2015-01-20 2:16 ` Eric Dumazet
2015-01-20 2:37 ` Dave Taht
2015-01-20 3:14 ` Eric Dumazet
2015-01-20 19:14 ` Rick Jones [this message]
2015-01-20 19:26 ` Eric Dumazet
2015-01-20 19:44 ` Rick Jones
2015-01-21 12:26 ` David Laight
2015-01-21 17:01 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BEA91D.1050001@hp.com \
--to=rick.jones2@hp.com \
--cc=amira@mellanox.com \
--cc=amirv@mellanox.com \
--cc=dave.taht@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=eyalpe@dev.mellanox.co.il \
--cc=eyalpe@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=idos@mellanox.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=ycheng@google.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).