From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5 4/5] can: kvaser_usb: Retry the first bulk transfer on -ETIMEDOUT Date: Wed, 21 Jan 2015 15:24:46 +0300 Message-ID: <54BF9A8E.7000202@cogentembedded.com> References: <20141223154654.GB6460@vivalin-002> <20150120214409.GA16828@linux> <20150120214537.GB16828@linux> <20150120214709.GC16828@linux> <20150120214834.GD16828@linux> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Andri Yngvason , Linux-CAN , netdev , LKML To: "Ahmed S. Darwish" , Olivier Sobrie , Oliver Hartkopp , Wolfgang Grandegger , Marc Kleine-Budde Return-path: In-Reply-To: <20150120214834.GD16828@linux> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 1/21/2015 12:48 AM, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > On some x86 laptops, plugging a Kvaser device again after an > unplug makes the firmware always ignore the very first command. > For such a case, provide some room for retries instead of > completly exiting the driver init code. Completely. > Signed-off-by: Ahmed S. Darwish > --- > drivers/net/can/usb/kvaser_usb.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c > index 640b0eb..068e76c 100644 > --- a/drivers/net/can/usb/kvaser_usb.c > +++ b/drivers/net/can/usb/kvaser_usb.c [...] > @@ -1632,7 +1632,15 @@ static int kvaser_usb_probe(struct usb_interface *intf, > > usb_set_intfdata(intf, dev); > > - err = kvaser_usb_get_software_info(dev); > + /* On some x86 laptops, plugging a Kvaser device again after > + * an unplug makes the firmware always ignore the very first > + * command. For such a case, provide some room for retries > + * instead of completly exiting the driver. Completely. [...] WBR, Sergei