From: Behan Webster <behanw@converseincode.com>
To: David Miller <davem@davemloft.net>
Cc: sathya.perla@emulex.com, ajit.khaparde@emulex.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
subbu.seetharaman@emulex.com, arnd@arndb.de
Subject: Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()
Date: Thu, 29 Jan 2015 10:25:09 -0800 [thread overview]
Message-ID: <54CA7B05.3000300@converseincode.com> (raw)
In-Reply-To: <20150128.224228.1533046356464752424.davem@davemloft.net>
On 01/28/15 22:42, David Miller wrote:
> From: Behan Webster <behanw@converseincode.com>
> Date: Wed, 28 Jan 2015 17:36:14 -0800
>
>> Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang.
>>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Why are you removing the device table?
It is defined more than once; removing the duplicate (as Arnd
indicated). My commit message was just completely wrong. Brain fart. Sorry.
> Second of all, your Subject needs to be adjusted, using "net" and
> "LLVMLinux" in your subsystem prefix is not appropriate. Simply
> "be2net: ", the name of this driver, is sufficient.
Will fix.
I've been in the habit of labelling the patches which go through the
LLVMLinux project like this so they are trivially identifiable in the
subject on lkml for reviewers and in the git log as being patches which
exist because of clang. If it's annoying I certainly don't need to do it.
Behan
--
Behan Webster
behanw@converseincode.com
prev parent reply other threads:[~2015-01-29 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 1:36 [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE() Behan Webster
2015-01-29 6:42 ` David Miller
2015-01-29 9:10 ` Arnd Bergmann
2015-01-29 11:29 ` Måns Rullgård
2015-01-29 18:21 ` Behan Webster
2015-01-29 18:25 ` Behan Webster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA7B05.3000300@converseincode.com \
--to=behanw@converseincode.com \
--cc=ajit.khaparde@emulex.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).