netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 1/6] rtlwifi: Change logging level for key change
Date: Fri, 30 Jan 2015 09:47:32 -0600	[thread overview]
Message-ID: <54CBA794.90508@lwfinger.net> (raw)
In-Reply-To: <1422304934-9239-2-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>

On 01/26/2015 02:42 PM, Larry Finger wrote:
> A recent change in key handling included logging of these changes for
> all debug levels. Such key changes should only be logged when a high
> level of debugging is enabled.
>
> Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
> ---
>   drivers/net/wireless/rtlwifi/cam.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
> index 3ef870d..6e64792 100644
> --- a/drivers/net/wireless/rtlwifi/cam.c
> +++ b/drivers/net/wireless/rtlwifi/cam.c
> @@ -406,7 +406,7 @@ u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
>   		}
>   	}
>   	if (found) {
> -		RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
> +		RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
>   			 "key_index=%d,cam_bitmap: 0x%x entry_idx=%d\n",
>   			  key_index, rtlpriv->sec.cam_bitmap, entry_idx);
>   		return entry_idx;
>

Kalle,

Please include this patch even though the rest of this set should be dropped. 
Once the wifi-BT communications problem is resolved, new versions of those will 
be presented.

I'm sorry that my commit message was not as informative as it could have been. I 
was presented with this material that I did not understand. One saving grace is 
that the RTL8812AE hardware is apparently rare - I certainly do not have any 
samples. I'm not sure of the value of a 1x1 implementation of 802.11ac, but that 
may be another example of my ignorance.

Thanks,

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-01-30 15:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 20:42 [PATCH 0/6 V2] Some changes for rtlwifi Larry Finger
2015-01-26 20:42 ` [PATCH V2 1/6] rtlwifi: Change logging level for key change Larry Finger
     [not found]   ` <1422304934-9239-2-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-30 15:47     ` Larry Finger [this message]
2015-02-03 13:01       ` Kalle Valo
2015-01-26 20:42 ` [PATCH V2 2/6] rtlwifi: btcoexist: Remove typedef statements Larry Finger
     [not found] ` <1422304934-9239-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-26 20:42   ` [PATCH V2 3/6] rtlwifi: btcoexist: Add routines for RTL8812AE with single antenna Larry Finger
2015-01-26 20:42 ` [PATCH V2 4/6] rtlwifi: btcoexist: Add routines for RTL8812AE with dual antennae Larry Finger
2015-01-26 20:42 ` [PATCH V2 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE kernel socket communications Larry Finger
     [not found]   ` <1422304934-9239-6-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-30  9:19     ` Kalle Valo
     [not found]       ` <87h9v8zkuh.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-01-30  9:57         ` Marcel Holtmann
2015-01-30 15:18           ` Larry Finger
     [not found]             ` <54CBA0CE.8030800-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-30 18:05               ` Marcel Holtmann
2015-02-03 12:29                 ` btcoex subsystem Kalle Valo
2015-02-12 20:28                   ` Marcel Holtmann
2015-01-26 20:42 ` [PATCH V2 6/6] rtlwifi: btcoexist: Enable new routines for RTL8812AE Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CBA794.90508@lwfinger.net \
    --to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public.gmane.org \
    --cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).