From: David L Stevens <david.stevens@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
Sowmini Varadhan <sowmini.varadhan@oracle.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH net] sunvnet: set queue mapping when doing packet copies
Date: Fri, 30 Jan 2015 12:29:45 -0500 [thread overview]
Message-ID: <54CBBF89.4070800@oracle.com> (raw)
In-Reply-To: <54C90AED.7040404@oracle.com>
This patch fixes a bug where vnet_skb_shape() didn't set the already-selected
queue mapping when a packet copy was required. This results in using the
wrong queue index for stops/starts, hung tx queues and watchdog timeouts
under heavy load.
Signed-off-by: David L Stevens <david.stevens@oracle.com>
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
--
I'm resubmitting this in its original form. Since skb_segment() doesn't do
TCP flow control either, due to an incorrect destructor check, and those
issues raised by Eric are a matter of fairness, while this missing queue_mapping
assignment results in crashes, I'd like to get this piece fixed separately.
---
drivers/net/ethernet/sun/sunvnet.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index 2b719cc..2b10b85 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -1123,6 +1123,7 @@ static inline struct sk_buff *vnet_skb_shape(struct sk_buff *skb, int ncookies)
skb_shinfo(nskb)->gso_size = skb_shinfo(skb)->gso_size;
skb_shinfo(nskb)->gso_type = skb_shinfo(skb)->gso_type;
}
+ nskb->queue_mapping = skb->queue_mapping;
dev_kfree_skb(skb);
skb = nskb;
}
--
1.7.1
next prev parent reply other threads:[~2015-01-30 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54C90AED.7040404@oracle.com>
2015-01-28 16:48 ` [PATCH net] sunvnet: set queue mapping when doing packet copies Sowmini Varadhan
2015-01-29 16:46 ` David L Stevens
2015-01-29 18:12 ` Eric Dumazet
2015-01-29 18:19 ` Eric Dumazet
2015-01-30 17:29 ` David L Stevens [this message]
2015-02-03 2:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBBF89.4070800@oracle.com \
--to=david.stevens@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).